fix: Made the alert-success styling explicit for learning mfe#38
fix: Made the alert-success styling explicit for learning mfe#38DawoudSheraz merged 2 commits intosumac/indigofrom
Conversation
paragon/_learning.scss
Outdated
| .row.w-100.mx-0.mb-4.border.border-light > .col-12 .alert.alert-success, | ||
| .streak-modal .alert.alert-success { |
There was a problem hiding this comment.
That is a bit too specific and can easily break with a small change upstream.
There was a problem hiding this comment.
Yes, that's true. I will try to find a way where we can target the specific mfe (learning in this case).
There was a problem hiding this comment.
Apparently, there is no way to identify a specific mfe. In my current implementation, I think for streak-modal, there is a very little or no chance that it will be changes in the future. But, for course celebration, I had to do this way as there was no better option I could find. I've also discussed this with @arbirali bhai and he thinks the same.
@DawoudSheraz
There was a problem hiding this comment.
@DawoudSheraz here is the relevant code snippet for Alert component used in CourseCelebration,
https://github.com/openedx/frontend-app-learning/blob/master/src/courseware/course/course-exit/CourseCelebration.jsx#L316
There is no generic parent class I could find that could make it a bit less specific. Your thoughts?
github-project-automation
bot
moved this from In review
to Done
in Tutor project management
3 participants
The styling for Alert component with success variant was being picked from _learning.scss file which was disturbing other mfes styling like in authn mfe forgot password page. This PR makes the alert styling explicit to only learning mfe so it won't effect any other mfes as we have separate scss files for each mfe.