feat: Design tokens implementations for the dark theme#47
Merged
Faraz32123 merged 1 commit intodark-theme-tokensfrom Feb 4, 2026
Merged
feat: Design tokens implementations for the dark theme#47Faraz32123 merged 1 commit intodark-theme-tokensfrom
Faraz32123 merged 1 commit intodark-theme-tokensfrom
Conversation
arbirali
changed the title
arbirali
force-pushed
the
rahat-dark-theme-tokens
branch
from
a9fa6d7 to
f18ef58
Compare
arbirali
force-pushed
the
rahat-dark-theme-tokens
branch
from
f18ef58 to
2fedde9
Compare
ahmed-arb
approved these changes
Feb 3, 2026
ahmed-arb
left a comment
ahmed-arb
left a comment
There was a problem hiding this comment.
I’m no styling expert, but this looks good to me.
I do have a concern about the dist folder. If we’ve decided to consume this brand in Indigo directly from GitHub (instead of npm), then we shouldn’t rely on developers to manually update dist in PRs.
We should either:
- set up a workflow to generate and commit dist automatically on every merge to ulmo, or
- remove dist from PRs entirely and rely solely on the workflow to generate it in the ulmo branch.
We can look into this separately.
Faraz32123
approved these changes
Feb 4, 2026
Faraz32123
pushed a commit
that referenced
this pull request
Feb 4, 2026
Faraz32123
pushed a commit
that referenced
this pull request
Feb 4, 2026
* fix: add dark theme tokens * feat: Design tokens implementations for the dark theme (#47) --------- Co-authored-by: Rahat Ali <rahat.ali@arbisoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.