fix: separate initialValue to not cause re-render on updates#9
Merged
eemaanamir merged 1 commit intodevelop-teak-wikilearnfrom Mar 1, 2026
Merged
Conversation
ahmed-arb
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: wikimedia/edx-platform#599
Description
This PR fixes re-render issue with TinyMCE which cause lost in state and the cursor position
Adding any text in course overview section in Schedule and Details Page causes the cursor to go back to initial point or at the very start of the editor.
This is because we are changing the initialValue of the Editor when we add/update any text which causes re-render.
Reference: https://www.tiny.cloud/docs/tinymce/5/react/#initialvalue
Testing instructions
Steps to Reproduce
Expected Behavior
Actual Behavior