Replace LZMA SDK with liblzma (from xz tools) #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edo9300
force-pushed
the
lzmalib
branch
2 times, most recently
from
5dd69bf to
04563a5
Compare
edo9300
force-pushed
the
master
branch
6 times, most recently
from
da29766 to
a4d64fe
Compare
edo9300
force-pushed
the
master
branch
3 times, most recently
from
c792ea4 to
0ed7d71
Compare
Currently it will "fail" decoding old replays as the lirbary assumes all the lzma streams are terminated by the end of stream block, whereas the replays were being generated without such block (still valid in the lzma standard)
Use lzma_alone_decoder that allows decompressing streams without an end of stream block. This requires feeding liblzma first a dummy lzma header so that it won't check for the eos block.
edo9300
force-pushed
the
master
branch
3 times, most recently
from
1ba4267 to
8424b09
Compare
edo9300
force-pushed
the
master
branch
6 times, most recently
from
1a62005 to
ef39fc3
Compare
edo9300
force-pushed
the
master
branch
2 times, most recently
from
96c64ac to
1ac735e
Compare
edo9300
force-pushed
the
master
branch
2 times, most recently
from
0bc55af to
0013228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use liblzma to compress/decompress replays, this removes the dependency on the lzma sdk.
The library implements the same lzma format as the sdk, so the generated replays should be compatible between the library and the sdk.