Consistent Deck sorting #279
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gallantron
commented
Nov 11, 2024
Comment on lines
+141
to
+143
| // player cards go before opponent cards | ||
| if (e1->controler != e2->controler) | ||
| return e1->controler < e2->controler; |
Contributor
Author
There was a problem hiding this comment.
upon review, i am unsure whether controler = 0 is always the player, and controler = 1 is always the opponent...
if not, is there a way to figure out who's who from this context? (presumably via mainGame though that feels hacky)
Contributor
Author
There was a problem hiding this comment.
I tested this, and it seems that controler = 0 is always the player... would still like a sanity check that I'm correct there, though
edo9300
force-pushed
the
master
branch
2 times, most recently
from
96c64ac to
1ac735e
Compare
edo9300
force-pushed
the
master
branch
2 times, most recently
from
0bc55af to
0013228
Compare
gallantron
force-pushed
the
feature/consistent-sorting
branch
from
81c1d8e to
3cc0627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes sorting of face-down cards in the player's Main Deck/Extra Deck to always be consistent, instead of dependent on the respective Deck's (randomized) order.
It also changes attached material to always be grouped immediately after the card it is attached to.