Conversation
Filtering settings based on script/mode
Deploying thorium-web with
|
| Latest commit: |
6badbdb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://089c8931.thorium-web.pages.dev |
| Branch Preview URL: | https://i18n-data.thorium-web.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements i18n-data from Readium CSS (readium/css#230)
Primarily, this leverages the
lineHeightCompensationfor the language in order to adjust the line-height presets to the publication’s language/script.E.g. for Japanese, if
ThLineHeight.looseis1.75it will be2– and1.75will be the value fornormal, which is to be expected as line-height is generally 10–20% more in Japanese – otherwise ourloosevalue would be what is expected asnormal.