fix: reduce success and failed job history limit to 0#12
Merged
BetoFandino merged 3 commits intomainfrom Feb 27, 2025
Merged
Conversation
…o 0 and failedjobshistorylimit to 1
Member
|
@BetoFandino the Title of the PR is confusing: "sidecar to clean pvc". It's just a configuration change to prevent having historic pods in the cron job, it is not the implementation of a sidecar :) |
BetoFandino
changed the title
Contributor
Author
|
@jfavellar90 Ready, sorry, the title was when I had made the previous commit |
Member
|
The title and commit still has a typo. Those are not variables they are fields. It should probably read something like 'fix: reduce success and failed job history limit to 0' and we should set both to 0. |
BetoFandino
changed the title
Contributor
Author
|
@MoisesGSalas. Thanks, let me know if the PR needs other fix |
MoisesGSalas
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change in the fields configuration:
In order not to leave pvc after a backup.