Merged
Conversation
…. Validation if the expiration rule already exists in the lifecycle.
jfavellar90
reviewed
Jan 22, 2026
jfavellar90
reviewed
Jan 26, 2026
| mc config host add minio http://minio:9000 {{ OPENEDX_AWS_ACCESS_KEY }} {{ OPENEDX_AWS_SECRET_ACCESS_KEY }} --api s3v4 | ||
| mc mb --ignore-existing minio/{{ BACKUP_BUCKET_NAME }} | ||
| {%- if BACKUP_MINIO_EXPIRATION_DAYS > 0 %} | ||
| {# validated if already exists expiration rule in backup bucket #} |
Member
There was a problem hiding this comment.
Please use bash comment as Tutor does here. Don't use template comments
Contributor
Author
There was a problem hiding this comment.
But in the example you gave me, it's in a .sh file. In this case, wouldn't there be problems with the file type format? I ask because jinja2 templates are used, and according to the comments I checked, it's with {# #}.
Member
There was a problem hiding this comment.
@BetoFandino at the end of the day, all tutor init jobs are run with sh, so this is essentially an sh-compatible script. In this order of ideas, it is safe to add the comment as I indicated. Besides, I want the comment to be rendered in the script, and jinja2 comments ARE NOT RENDERED in the final output.
jfavellar90
approved these changes
Jan 27, 2026
BetoFandino
added a commit
that referenced
this pull request
Mar 10, 2026
* feat: A new variable has been added to validate whether minio is used. Validation if the expiration rule already exists in the lifecycle. * feat: validated with snipper value * fix: decorator of plugin loaded * fix: deleted variable not used minio_enabled * fix: deleted return config in plugin * fix: validation of ilm on rules * feat: taked action and filter to validate list * feat: taked filter to validate list * fix: return list of plugins * feat: added comments in minio init * feat: use actions and take plugins list by filter * fix: comments in init minio * fix: format of comments
BetoFandino
added a commit
that referenced
this pull request
Mar 10, 2026
* feat: A new variable has been added to validate whether minio is used. Validation if the expiration rule already exists in the lifecycle. * feat: validated with snipper value * fix: decorator of plugin loaded * fix: deleted variable not used minio_enabled * fix: deleted return config in plugin * fix: validation of ilm on rules * feat: taked action and filter to validate list * feat: taked filter to validate list * fix: return list of plugins * feat: added comments in minio init * feat: use actions and take plugins list by filter * fix: comments in init minio * fix: format of comments
BetoFandino
added a commit
that referenced
this pull request
Mar 11, 2026
* feat: A new variable has been added to validate whether minio is used. Validation if the expiration rule already exists in the lifecycle. * feat: validated with snipper value * fix: decorator of plugin loaded * fix: deleted variable not used minio_enabled * fix: deleted return config in plugin * fix: validation of ilm on rules * feat: taked action and filter to validate list * feat: taked filter to validate list * fix: return list of plugins * feat: added comments in minio init * feat: use actions and take plugins list by filter * fix: comments in init minio * fix: format of comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added two changes in minio task: