Skip to content

Comments

feat: making the color of the email button variable#175

Draft
DeimerM wants to merge 2 commits intomasterfrom
dmh/configure-button-color
Draft

feat: making the color of the email button variable#175
DeimerM wants to merge 2 commits intomasterfrom
dmh/configure-button-color

Conversation

@DeimerM
Copy link
Contributor

@DeimerM DeimerM commented Aug 18, 2023

Hi team, I hope you all are doing great !!

This PR is intended to make the color of the emails button variable, this so that there is consistency with the colors that are placed when configuring these settings "email_button__color" and "email_button__background", since when configuring this setting in our tenants it remains as follows.

Screenshot from 2023-08-17 22-47-57

The code that is currently responsible for configuring these colors can be found below.

style="
color: {{ EMAIL_COLORS.email_button__color|default:"#4c4b4b" }};
text-decoration: none;
border-radius: 4px;
-webkit-border-radius: 4px;
-moz-border-radius: 4px;
background-color: {{ EMAIL_COLORS.email_button__background|default:"#2e9fd8" }};
border-top: 12px solid {{ EMAIL_COLORS.email_button__border|default:"#2e9fd8" }};
border-bottom: 12px solid {{ EMAIL_COLORS.email_button__border|default:"#2e9fd8" }};
border-right: 50px solid {{ EMAIL_COLORS.email_button__border|default:"#2e9fd8" }};
border-left: 50px solid {{ EMAIL_COLORS.email_button__border|default:"#2e9fd8" }};
display: inline-block;
">
{# old email clients require the use of the font tag :( #}
<font color="{{ EMAIL_COLORS.email_button__color|default:"#4c4b4b" }}"><b>{{ course_cta_text }}</b></font>
</a>

How to test

  1. Add the following setting in your site's tenant config.
"EMAIL_COLORS": {
    "email_button__background": "#000000",
    "email_button__color": "#ffffff"
}
  1. Send emails from your site to test the button looks great.

@bra-i-am
Copy link
Contributor

Hi @DeimerM, I hope you are doing great!

Could you please give me an update about this PR?

Thank you!! :D

@dcoa dcoa removed their assignment Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants