Skip to content

feat: added css variables support to sumac#7

Merged
Asespinel merged 2 commits intoopen-release/sumac.masterfrom
ase/added-css-variables-support-sumac
Jan 22, 2025
Merged

feat: added css variables support to sumac#7
Asespinel merged 2 commits intoopen-release/sumac.masterfrom
ase/added-css-variables-support-sumac

Conversation

@Asespinel
Copy link

Description

This PR intends to add CSS Variables support to th Sumac release.

How to Test

  1. Create a Sumac environment you can use Tutor or TVM.
  2. Mount this MFE using this branch using tutor mounts add path/to/learning
  3. Run tutor config save
  4. Add this config to you development.py file or to your tenant settings:
MFE_CONFIG["PARAGON_THEME_URLS"] = {
    "core": {
        "url": "https://cdn.jsdelivr.net/npm/@openedx/paragon@$paragonVersion/dist/core.min.css"
    },
    "defaults": {
        "light": "light"
    },
    "variants": {
        "light": {
            "url": "https://cdn.jsdelivr.net/npm/@openedx/paragon@$paragonVersion/dist/light.min.css"
        }
    }
}

Copy link

@jignaciopm jignaciopm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's solve the linter errors, they are easy to solve

Copy link

@jignaciopm jignaciopm Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Asespinel I think we should add this to a .env and .env.development

@Asespinel Asespinel merged commit 7e054f3 into open-release/sumac.master Jan 22, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments