Skip to content

feat: add css variables support sumac#5

Merged
jignaciopm merged 1 commit intoednx-release/sumac.masterfrom
jipm/added-css-variables-support-sumac
Jan 22, 2025
Merged

feat: add css variables support sumac#5
jignaciopm merged 1 commit intoednx-release/sumac.masterfrom
jipm/added-css-variables-support-sumac

Conversation

@jignaciopm
Copy link

@jignaciopm jignaciopm commented Jan 16, 2025

Description

This PR intends to add CSS Variables support to th Sumac release.

How to Test

  1. Create a Sumac environment you can use Tutor or TVM.
  2. Mount this MFE using this branch using tutor mounts add path/to/learner-dashboard
  3. Run tutor config save
  4. Add this config to you development.py file or to your tenant settings:
MFE_CONFIG["PARAGON_THEME_URLS"] = {
    "core": {
        "url": "https://cdn.jsdelivr.net/npm/@openedx/paragon@23.0.0-alpha.7/dist/core.min.css"
    },
    "defaults": {
        "light": "light"
    },
    "variants": {
        "light": {
            "url": "https://css-varsify.s3.amazonaws.com/public/6d17ef6a-a0e0-41ce-a08e-01b6fffa1b17.css"
        }
    }
}

@jignaciopm jignaciopm force-pushed the jipm/added-css-variables-support-sumac branch from 6e29d33 to 75d8005 Compare January 16, 2025 03:10
Copy link

@Asespinel Asespinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@jignaciopm jignaciopm merged commit fa0c190 into ednx-release/sumac.master Jan 22, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments