-
Notifications
You must be signed in to change notification settings - Fork 6
fix: update Python version to 3.11 and use latest setup-python action in workflows #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ttak-apphelix
wants to merge
11
commits into
master
Choose a base branch
from
ttak/BOMS-408
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
10eb5c8
fix: update Python version to 3.10 and use latest setup-python action…
ttak-apphelix d2e12cb
fix: update Python version to 3.10 and use latest setup-python action…
ttak-apphelix 7a61516
fix: update dependency file reference to requirements3_12.txt in work…
ttak-apphelix 96244aa
fix: ansible constraint to <9.0.0 to maintain compatibility with play…
ttak-apphelix 5ad0191
fix: downgrade ansible to 8.7.0 and ansible-core to 2.15.13 for compa…
ttak-apphelix 4b1d3a6
fix: update Python version to 3.11 in workflows
ttak-apphelix 917dce2
fix: update requirements to use Python 3.11
ttak-apphelix d3b0fdb
Merge branch 'master' into ttak/BOMS-408
ttak-apphelix 1c9317f
fix: downgrade ansible version to <9.0.0 for compatibility
ttak-apphelix 8c11f2f
fix: update dependencies and remove obsolete requirement files
ttak-apphelix f52e152
fix: updated comments
ttak-apphelix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,11 @@ | ||
| -c common_constraints.txt | ||
|
|
||
| bcrypt<3.2.0 # 3.2.0 dropped support for python 2.7 | ||
|
|
||
| # Python 3.9 reached EOL in October 2025 and was removed from GitHub Actions runners | ||
| # GitHub Actions workflows now use Python 3.11 | ||
| # Ansible 9+ supports Python 3.11+ but removed the deprecated 'include' syntax causing playbook failures | ||
| # Ansible 8.7.0 is the latest version that supports both Python 3.11 AND the deprecated 'include' syntax | ||
| # The constraint can be removed once all 63 instances of 'include' are migrated to 'include_tasks' or 'import_tasks' | ||
| # Tracking: Configuration playbooks need migration before upgrading to Ansible 9+ | ||
| ansible<9.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 3.12? (To match requirements file.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, plan is to update this to 3.12. But current challenge is Ansible 9+ removed support for deprecated include syntax used in playbooks and lower version(ansible<9.0.0) is not supported on 3.12.
Plan is to create a separate PR which will require a SRE support where they can validate all the changes and update this to 3.12 with updated Ansible version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks! (Might be good to include this in the PR description, and the commit message when you squash.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requirements3_11.txt(assuming we even need multiple requirements files), would help avoid some confusion.