Skip to content

fix: Another attempt at fixing git-clean permission issues (chown -R)#325

Merged
robrap merged 1 commit intomasterfrom
timmc/clean-chown
Feb 24, 2026
Merged

fix: Another attempt at fixing git-clean permission issues (chown -R)#325
robrap merged 1 commit intomasterfrom
timmc/clean-chown

Conversation

@timmc-edx
Copy link
Member

We're still seeing the issue. Remove the safe-directory stuff (which might have worked if we dropped the become_user, but was probably more complicated than necessary) and instead just chown -R the repo before doing the clean. Hopefully that does it.


Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

We're still seeing the issue. Remove the safe-directory stuff (which might
have worked if we dropped the `become_user`, but was probably more
complicated than necessary) and instead just `chown -R` the repo before
doing the clean. Hopefully that does it.
@timmc-edx
Copy link
Member Author

CI failures are known and unrelated (being worked on by Orbi-BOM).

Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll give this a try and see what happens. Thanks.

@robrap robrap merged commit 8932c15 into master Feb 24, 2026
1 of 3 checks passed
@robrap robrap deleted the timmc/clean-chown branch February 24, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants