Skip to content

fix: update release-ulmo branch triggers for pylint and dunder init workflows#177

Merged
Akanshu-2u merged 3 commits intorelease-ulmofrom
aaich/add-ci-run-ulmo
Mar 12, 2026
Merged

fix: update release-ulmo branch triggers for pylint and dunder init workflows#177
Akanshu-2u merged 3 commits intorelease-ulmofrom
aaich/add-ci-run-ulmo

Conversation

@Akanshu-2u
Copy link

@Akanshu-2u Akanshu-2u commented Mar 11, 2026

Description:

Updates GitHub Actions workflow triggers so the release-ulmo branch is included for pylint and dunder-__init__.py verification runs, aligning these checks with the release branch workflow.

Changes:

  • Added a push trigger for the dunder __init__.py verification workflow on release-ulmo.
  • Updated the pylint workflow push branch filter from master to release-ulmo.

Copilot AI review requested due to automatic review settings March 11, 2026 13:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GitHub Actions workflow triggers so the release-ulmo branch is included for pylint and dunder-__init__.py verification runs, aligning these checks with the release branch workflow.

Changes:

  • Added a push trigger for the dunder __init__.py verification workflow on release-ulmo.
  • Updated the pylint workflow push branch filter from master to release-ulmo.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/verify-dunder-init.yml Adds push trigger on release-ulmo so the workflow runs on direct updates to the release branch.
.github/workflows/pylint-checks.yml Changes push trigger branch filter to release-ulmo so pylint runs on release branch pushes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It's probably fine to merge as-is, but I would (and did) wonder whether this was fixed in openedx for verify-dunder-init.yml? Did you also review? See my related comment.


on:
pull_request:
push:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if it might make sense to cherry-pick the following commits first, to minimize conflicts during ulmo.1 merge:

bradenmacdonald and others added 2 commits March 12, 2026 09:22
This check was previously only running on PRs to master, which makes it annoying to stack PRs and have all the checks run.  Update it so that the check runs on all PRs and on pushes to master.
@Akanshu-2u Akanshu-2u merged commit c187ac4 into release-ulmo Mar 12, 2026
64 checks passed
@Akanshu-2u Akanshu-2u deleted the aaich/add-ci-run-ulmo branch March 12, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants