fix: update release-ulmo branch triggers for pylint and dunder init workflows#177
fix: update release-ulmo branch triggers for pylint and dunder init workflows#177Akanshu-2u merged 3 commits intorelease-ulmofrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflow triggers so the release-ulmo branch is included for pylint and dunder-__init__.py verification runs, aligning these checks with the release branch workflow.
Changes:
- Added a
pushtrigger for the dunder__init__.pyverification workflow onrelease-ulmo. - Updated the pylint workflow
pushbranch filter frommastertorelease-ulmo.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/verify-dunder-init.yml | Adds push trigger on release-ulmo so the workflow runs on direct updates to the release branch. |
| .github/workflows/pylint-checks.yml | Changes push trigger branch filter to release-ulmo so pylint runs on release branch pushes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
robrap
left a comment
There was a problem hiding this comment.
Thanks. It's probably fine to merge as-is, but I would (and did) wonder whether this was fixed in openedx for verify-dunder-init.yml? Did you also review? See my related comment.
|
|
||
| on: | ||
| pull_request: | ||
| push: |
There was a problem hiding this comment.
Unsure if it might make sense to cherry-pick the following commits first, to minimize conflicts during ulmo.1 merge:
This check was previously only running on PRs to master, which makes it annoying to stack PRs and have all the checks run. Update it so that the check runs on all PRs and on pushes to master.
Description:
Updates GitHub Actions workflow triggers so the
release-ulmobranch is included forpylintanddunder-__init__.pyverification runs, aligning these checks with the release branch workflow.Changes:
dunder __init__.pyverification workflow onrelease-ulmo.mastertorelease-ulmo.