Skip to content

feat: enterprise 6.6.8, begins decoupling retirement view#179

Merged
iloveagent57 merged 1 commit intorelease-ulmofrom
aed/enterprise-6.6.8
Mar 12, 2026
Merged

feat: enterprise 6.6.8, begins decoupling retirement view#179
iloveagent57 merged 1 commit intorelease-ulmofrom
aed/enterprise-6.6.8

Conversation

@iloveagent57
Copy link
Member

Includes logic to send signal with args now required by enterprise signal handlers in: openedx/edx-enterprise#2559

Deployments of new edx-enterprise releases, including:
https://github.com/edx/edx-platform/pull/175/changes

are blocked until this PR is merged. They are blocked because CI fails on pytest openedx/core/djangoapps/user_api/accounts/tests/test_retirement_views.py due to a signal expecting required args that are not present without this fix.

Copilot AI review requested due to automatic review settings March 12, 2026 14:51
@iloveagent57 iloveagent57 enabled auto-merge (rebase) March 12, 2026 14:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR unblocks upgrading edx-enterprise by updating the LMS retirement signal emission to include newly-required kwargs expected by enterprise signal handlers, and bumps the pinned edx-enterprise dependency to 6.6.8.

Changes:

  • Bump edx-enterprise from 6.6.7 to 6.6.8 across constraints and edx requirements files.
  • Update USER_RETIRE_LMS_CRITICAL.send(...) to include retired_email and retired_username.
  • Add Claude-related entries to .gitignore (currently duplicated with existing entries).

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
requirements/edx/testing.txt Pins edx-enterprise==6.6.8 for test environment consistency.
requirements/edx/doc.txt Pins edx-enterprise==6.6.8 for docs environment consistency.
requirements/edx/development.txt Pins edx-enterprise==6.6.8 for dev environment consistency.
requirements/edx/base.txt Pins edx-enterprise==6.6.8 for base environment consistency.
requirements/constraints.txt Updates the central constraint to edx-enterprise==6.6.8.
openedx/core/djangoapps/user_api/accounts/views.py Sends required retirement kwargs on USER_RETIRE_LMS_CRITICAL to satisfy enterprise handlers.
.gitignore Adds Claude ignore entries (but duplicates existing ones earlier in the file).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@iloveagent57 iloveagent57 merged commit 3691de4 into release-ulmo Mar 12, 2026
68 checks passed
@iloveagent57 iloveagent57 deleted the aed/enterprise-6.6.8 branch March 12, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants