feat: enterprise 6.6.8, begins decoupling retirement view#179
Merged
iloveagent57 merged 1 commit intorelease-ulmofrom Mar 12, 2026
Merged
feat: enterprise 6.6.8, begins decoupling retirement view#179iloveagent57 merged 1 commit intorelease-ulmofrom
iloveagent57 merged 1 commit intorelease-ulmofrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR unblocks upgrading edx-enterprise by updating the LMS retirement signal emission to include newly-required kwargs expected by enterprise signal handlers, and bumps the pinned edx-enterprise dependency to 6.6.8.
Changes:
- Bump
edx-enterprisefrom6.6.7to6.6.8across constraints and edx requirements files. - Update
USER_RETIRE_LMS_CRITICAL.send(...)to includeretired_emailandretired_username. - Add Claude-related entries to
.gitignore(currently duplicated with existing entries).
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| requirements/edx/testing.txt | Pins edx-enterprise==6.6.8 for test environment consistency. |
| requirements/edx/doc.txt | Pins edx-enterprise==6.6.8 for docs environment consistency. |
| requirements/edx/development.txt | Pins edx-enterprise==6.6.8 for dev environment consistency. |
| requirements/edx/base.txt | Pins edx-enterprise==6.6.8 for base environment consistency. |
| requirements/constraints.txt | Updates the central constraint to edx-enterprise==6.6.8. |
| openedx/core/djangoapps/user_api/accounts/views.py | Sends required retirement kwargs on USER_RETIRE_LMS_CRITICAL to satisfy enterprise handlers. |
| .gitignore | Adds Claude ignore entries (but duplicates existing ones earlier in the file). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pwnage101
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes logic to send signal with args now required by enterprise signal handlers in: openedx/edx-enterprise#2559
Deployments of new edx-enterprise releases, including:
https://github.com/edx/edx-platform/pull/175/changes
are blocked until this PR is merged. They are blocked because CI fails on
pytest openedx/core/djangoapps/user_api/accounts/tests/test_retirement_views.pydue to a signal expecting required args that are not present without this fix.