Skip to content

fix: removing enterprise-specific code from edx-platform#180

Merged
kiram15 merged 3 commits intorelease-ulmofrom
kiram15/ENT_11476
Mar 12, 2026
Merged

fix: removing enterprise-specific code from edx-platform#180
kiram15 merged 3 commits intorelease-ulmofrom
kiram15/ENT_11476

Conversation

@kiram15
Copy link

@kiram15 kiram15 commented Mar 12, 2026

Removing enterprise specific code, sister PR to this one in openedx-platform here.

Jira ticket

Description

Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

Copilot AI review requested due to automatic review settings March 12, 2026 20:23
@kiram15 kiram15 changed the title Kiram15/ent 11476 fix: removing enterprise-specific code from edx-platform Mar 12, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes enterprise-specific user retirement code from openedx-platform, as part of moving that responsibility elsewhere (sister PR in openedx-platform). The enterprise retirement methods (retire_users_data_sharing_consent, retire_sapsf_data_transmission, retire_degreed_data_transmission, retire_user_from_pending_enterprise_customer_user) and their tests are removed. A new test verifies that the USER_RETIRE_LMS_CRITICAL signal is sent with the correct retirement data, allowing enterprise retirement to be handled by signal receivers.

Changes:

  • Removed enterprise-specific retirement methods and their invocations from AccountRetirementView.post()
  • Removed corresponding enterprise test setup, assertions, and test methods
  • Added a new test to verify USER_RETIRE_LMS_CRITICAL signal is sent with retired_username and retired_email

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
openedx/core/djangoapps/user_api/accounts/views.py Removed enterprise model imports, enterprise retirement method calls, and enterprise retirement method definitions
openedx/core/djangoapps/user_api/accounts/tests/test_retirement_views.py Removed enterprise imports, test setup, assertion helpers, and test methods; added signal-sending test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@kiram15 kiram15 force-pushed the kiram15/ENT_11476 branch from ec40a39 to 36f93e3 Compare March 12, 2026 21:09
Copilot AI review requested due to automatic review settings March 12, 2026 21:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@kiram15 kiram15 merged commit 2d4da85 into release-ulmo Mar 12, 2026
68 checks passed
@kiram15 kiram15 deleted the kiram15/ENT_11476 branch March 12, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants