fix: show staff tag for global staff in discussion forum#187
Open
Alam-2U wants to merge 1 commit intorelease-ulmofrom
Open
fix: show staff tag for global staff in discussion forum#187Alam-2U wants to merge 1 commit intorelease-ulmofrom
Alam-2U wants to merge 1 commit intorelease-ulmofrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes global staff users being displayed as "learner" in the discussion forum by checking User.is_staff before the course-level role check.
Changes:
- Adds a global staff check at the top of
_get_user_labelto return "Staff" for Django superusers/staff before falling through to course-level role checks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Returns the role label (i.e. "Staff", "Moderator" or "Community TA") for the user | ||
| with the given id. | ||
| """ | ||
| if User.objects.get(id=user_id).is_staff: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Global staff users were being displayed as learners in the discussion forum, and the staff tag was not shown.
Issue :
The course staff check was overriding the global staff check. As a result, if a user was not marked as course staff, they were displayed as a learner even if they had global staff privileges.
Ticket :
COSMO2-842