Closed
Conversation
fix: fixed tests and quality failures
There was a problem hiding this comment.
Pull Request Overview
This PR appears to combine two distinct changes: updates to the GeoLite database workflow configuration and implementation of conditional imports to support migration from integrated_channels to channel_integrations modules. The workflow now targets the release-ulmo branch instead of master, updates reviewer assignments, and uses improved variable quoting. The Python code changes introduce a feature flag (ENABLE_LEGACY_INTEGRATED_CHANNELS) to enable gradual migration between two different module structures.
- Updated GeoLite database workflow to target
release-ulmobranch and use new reviewer assignments - Implemented conditional imports across multiple files to support
integrated_channelstochannel_integrationsmigration - Updated test mocking to dynamically select the correct import path based on feature flag
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/update-geolite-database.yml |
Updated workflow to target release-ulmo branch, improved shell variable quoting, changed reviewer to edx/orbi-bom, and updated GitHub token reference |
openedx/features/enterprise_support/signals.py |
Added conditional imports for task functions based on ENABLE_LEGACY_INTEGRATED_CHANNELS setting |
openedx/features/enterprise_support/tests/test_signals.py |
Updated test mocks to dynamically select import paths using the same conditional logic |
openedx/core/djangoapps/user_api/management/commands/create_user_gdpr_testing.py |
Added conditional import for SapSuccessFactorsLearnerDataTransmissionAudit model |
openedx/core/djangoapps/user_api/accounts/views.py |
Added conditional imports for Degreed and SAP SuccessFactors audit models with aliasing for compatibility |
openedx/core/djangoapps/user_api/accounts/tests/test_retirement_views.py |
Added conditional import for SapSuccessFactorsLearnerDataTransmissionAudit in test file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR generated by workflow on behalf of @ktyagiapphelix2u.