fix: upgrade hls.js to version 1.6.15 and update related imports in video player tests#57
Conversation
papphelix
commented
Dec 8, 2025
- This Pull request is for testing if hls player upgrade workes in stage, if works the actual request will be opened to openedx and will be cherry-picked to edx release-ulmo
…ideo player tests
There was a problem hiding this comment.
Pull request overview
This PR upgrades the hls.js library from version 0.14.17 to 1.6.15 and updates test references from HLS to Hls to match the exported name convention. This is a test PR to validate the upgrade works in staging before creating the actual PR for Open edX.
Key changes:
- Upgraded hls.js package from 0.14.17 to ^1.6.15
- Updated test spy calls from
HLS.isSupportedtoHls.isSupported - Added ES6 import statements (though they conflict with existing RequireJS patterns)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Updated hls.js version from 0.14.17 to ^1.6.15 |
| package-lock.json | Updated hls.js dependency tree, removed eventemitter3 and url-toolkit dependencies that were required by v0.14.17 but not v1.6.15 |
| xmodule/js/spec/video/video_player_spec.js | Updated test spies to use Hls instead of HLS, but introduced problematic ES6 imports that conflict with RequireJS pattern |
Comments suppressed due to low confidence (2)
xmodule/js/spec/video/video_player_spec.js:3
- Unused import VideoPlayer.
import VideoPlayer from "../../../assets/video/public/js/03_video_player.js";
xmodule/js/spec/video/video_player_spec.js:1104
- Superfluous arguments passed to anonymous function.
}(require, define));
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@papphelix Is local testing possible, or do we need to verify this in staging instead? |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
xmodule/js/spec/video/video_player_spec.js:1100
- Superfluous arguments passed to anonymous function.
}(require, define));
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Local testing was not working. I tried local file storage to upload a file and test, I had tried remote sample mp4 also a stream m3u8 file, but error happens loading the video player. So to quick fix i have raised this to stage and test. I am also checking how to fix this in local setup. |
…ing in video player spec