Revert "Revert "fix: upgrade hls.js to version 1.6.15 and update related imports in video player tests""#62
Merged
viv-helix merged 1 commit intorelease-ulmofrom Dec 11, 2025
Conversation
…ted impo…" This reverts commit f348776.
viv-helix
approved these changes
Dec 11, 2025
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous revert, thereby re-applying changes that upgrade the hls.js library from version 0.14.17 to 1.6.15. The upgrade includes updating the package dependency and consistently renaming all references from HLS to Hls throughout the video player codebase to align with hls.js v1.x API conventions.
Key Changes:
- Upgrades hls.js from 0.14.17 to ^1.6.15 in package dependencies
- Renames all
HLSimport references toHlsacross video player and test files - Removes transitive dependencies (url-toolkit, eventemitter3, buffer, base64-js, ieee754) that are no longer required by hls.js v1.x
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates hls.js dependency from 0.14.17 to ^1.6.15 |
| package-lock.json | Updates hls.js package metadata and removes obsolete transitive dependencies |
| xmodule/js/src/video/03_video_player.js | Renames HLS import to Hls and updates API calls (isSupported) |
| xmodule/js/src/video/02_html5_hls_video.js | Renames HLS import to Hls and updates all API references (constructor, Events, ErrorTypes) |
| xmodule/js/spec/video/video_player_spec.js | Updates test file with Hls import and modifies IIFE signature |
Comments suppressed due to low confidence (1)
xmodule/js/spec/video/video_player_spec.js:1101
- Superfluous arguments passed to anonymous function.
}(require, define));
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #59