Skip to content

fix :alignment solved for mobile interface #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssurendrannair merged 3 commits into from
Mar 9, 2026
Merged

fix :alignment solved for mobile interface #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f55e7c
fix: alignment solved for mobile interface
ssurendrannair Mar 6, 2026
86f83e8
fix: remove trailing whitespace in SmallLayout
ssurendrannair Mar 6, 2026
4c897cd
fix: solve alignment issue for mobile interface
ssurendrannair Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/base-container/components/welcome-page-layout/MediumLayout.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const MediumLayout = () => {
</div>
)}

<div className="auth-hero-slash" aria-hidden="true">
<div className="auth-hero-slash mr-4" aria-hidden="true">
<svg xmlns="http://www.w3.org/2000/svg" width="191" height="250" viewBox="0 0 191 250" fill="none" style={{ width: '100%', height: '100%' }}>
<line x1="69.8107" y1="33.833" x2="32.9503" y2="206.952" stroke="#F0CC00" strokeWidth="8" />
</svg>
Expand All @@ -62,7 +62,7 @@ const MediumLayout = () => {

{enterpriseWelcomeHtml && (
<div
className="auth-hero-message mt-4"
className="auth-hero-message mt-3"
// eslint-disable-next-line react/no-danger
dangerouslySetInnerHTML={{
__html: enterpriseWelcomeHtml,
Expand Down
4 changes: 2 additions & 2 deletions src/base-container/components/welcome-page-layout/SmallLayout.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<div className="auth-hero-content d-flex flex-column">
<div className="d-flex align-items-center">
{enterpriseLogoUrl && (
<div className="auth-hero-enterprise-logo-wrapper mr-3">
<div className="auth-hero-enterprise-logo-wrapper mr-4">
<Image
alt={enterpriseName || 'Enterprise'}
src={enterpriseLogoUrl}
Expand All @@ -42,7 +42,7 @@
</div>
)}

<div className="auth-hero-slash" aria-hidden="true">
<div className="auth-hero-slash mr-4" aria-hidden="true">
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says the UI is now consistent across platforms, but MediumLayout still renders the slash without the mr-4 spacing that LargeLayout and this updated SmallLayout now use. To avoid inconsistent spacing between responsive breakpoints, either update src/base-container/components/welcome-page-layout/MediumLayout.jsx to match (add mr-4 on the auth-hero-slash container) or adjust the PR description/scope to clarify it's a small-screen-only fix.

Copilot uses AI. Check for mistakes.
<svg xmlns="http://www.w3.org/2000/svg" width="191" height="250" viewBox="0 0 191 250" fill="none" style={{ width: '100%', height: '100%' }}>
<line x1="69.8107" y1="33.833" x2="32.9503" y2="206.952" stroke="#F0CC00" strokeWidth="8" />
</svg>
Expand All @@ -63,7 +63,7 @@
className="auth-hero-message mt-3"
// eslint-disable-next-line react/no-danger
// HTML is provided by trusted enterprise branding config (sanitized upstream).
dangerouslySetInnerHTML={{

Check warning on line 66 in src/base-container/components/welcome-page-layout/SmallLayout.jsx

View workflow job for this annotation

GitHub Actions / tests 

Dangerous property 'dangerouslySetInnerHTML' found
__html: enterpriseWelcomeHtml,
}}
/>
Expand Down
Loading