Skip to content

fix: resolve issue with Xpert unit summary toggle not updating state #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alam-2U wants to merge 1 commit into
base: release-ulmo
Choose a base branch
from
+20 −20
Open

fix: resolve issue with Xpert unit summary toggle not updating state #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/course-apps/xpert_unit_summary/Settings.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const XpertUnitSummarySettings = () => {

return (
<SettingsModal
appId="xpert-unit-summary"
appId="xpert_unit_summary"
title={intl.formatMessage(messages.heading)}
enableAppHelp={intl.formatMessage(messages.enableXpertUnitSummaryHelp)}
helpPrivacyText={intl.formatMessage(messages.enableXpertUnitSummaryHelpPrivacyLink)}
Expand Down
28 changes: 14 additions & 14 deletions plugins/course-apps/xpert_unit_summary/Settings.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ describe('XpertUnitSummarySettings', () => {

test('Shows switch on if enabled from backend', async () => {
const enableBadge = await findByTestId(container, 'enable-badge');
expect(container.querySelector('#enable-xpert-unit-summary-toggle').checked).toBeTruthy();
expect(container.querySelector('#enable-xpert_unit_summary-toggle').checked).toBeTruthy();
expect(enableBadge).toBeTruthy();
});

Expand All @@ -119,13 +119,13 @@ describe('XpertUnitSummarySettings', () => {
}));

renderComponent();
await waitFor(() => expect(container.querySelector('#enable-xpert-unit-summary-toggle')).toBeTruthy());
expect(container.querySelector('#enable-xpert-unit-summary-toggle').checked).toBeTruthy();
await waitFor(() => expect(container.querySelector('#enable-xpert_unit_summary-toggle')).toBeTruthy());
expect(container.querySelector('#enable-xpert_unit_summary-toggle').checked).toBeTruthy();
expect(queryByTestId(container, 'enable-badge')).toBeTruthy();
});

test('Shows enable radio selected if enabled from backend', async () => {
await waitFor(() => expect(container.querySelector('#enable-xpert-unit-summary-toggle')).toBeTruthy());
await waitFor(() => expect(container.querySelector('#enable-xpert_unit_summary-toggle')).toBeTruthy());
expect(queryByTestId(container, 'enable-radio').checked).toBeTruthy();
});

Expand All @@ -137,7 +137,7 @@ describe('XpertUnitSummarySettings', () => {
}));

renderComponent();
await waitFor(() => expect(container.querySelector('#enable-xpert-unit-summary-toggle')).toBeTruthy());
await waitFor(() => expect(container.querySelector('#enable-xpert_unit_summary-toggle')).toBeTruthy());
expect(queryByTestId(container, 'disable-radio').checked).toBeTruthy();
});
});
Expand All @@ -154,8 +154,8 @@ describe('XpertUnitSummarySettings', () => {
});

test('Does not show as enabled if configuration does not exist', async () => {
await waitFor(() => expect(container.querySelector('#enable-xpert-unit-summary-toggle')).toBeTruthy());
expect(container.querySelector('#enable-xpert-unit-summary-toggle').checked).not.toBeTruthy();
await waitFor(() => expect(container.querySelector('#enable-xpert_unit_summary-toggle')).toBeTruthy());
expect(container.querySelector('#enable-xpert_unit_summary-toggle').checked).not.toBeTruthy();
expect(queryByTestId(container, 'enable-badge')).not.toBeTruthy();
});
});
Expand All @@ -180,11 +180,11 @@ describe('XpertUnitSummarySettings', () => {
test('Saving configuration changes', async () => {
jest.spyOn(API, 'postXpertSettings');

await waitFor(() => expect(container.querySelector('#enable-xpert-unit-summary-toggle')).toBeTruthy());
await waitFor(() => expect(container.querySelector('#enable-xpert_unit_summary-toggle')).toBeTruthy());
expect(queryByTestId(container, 'disable-radio').checked).toBeTruthy();
fireEvent.click(queryByTestId(container, 'enable-radio'));
fireEvent.click(getByText(container, 'Save'));
await waitFor(() => expect(container.querySelector('#enable-xpert-unit-summary-toggle')).toBeTruthy());
await waitFor(() => expect(container.querySelector('#enable-xpert_unit_summary-toggle')).toBeTruthy());
expect(API.postXpertSettings).toBeCalled();
});
});
Expand Down Expand Up @@ -226,10 +226,10 @@ describe('XpertUnitSummarySettings', () => {
test('Deleting course configuration', async () => {
jest.spyOn(API, 'deleteXpertSettings');

await waitFor(() => expect(container.querySelector('#enable-xpert-unit-summary-toggle')).toBeTruthy());
fireEvent.click(container.querySelector('#enable-xpert-unit-summary-toggle'));
await waitFor(() => expect(container.querySelector('#enable-xpert_unit_summary-toggle')).toBeTruthy());
fireEvent.click(container.querySelector('#enable-xpert_unit_summary-toggle'));
fireEvent.click(getByText(container, 'Save'));
await waitFor(() => expect(container.querySelector('#enable-xpert-unit-summary-toggle')).toBeTruthy());
await waitFor(() => expect(container.querySelector('#enable-xpert_unit_summary-toggle')).toBeTruthy());
expect(API.deleteXpertSettings).toBeCalled();
});
});
Expand All @@ -252,7 +252,7 @@ describe('XpertUnitSummarySettings', () => {

jest.spyOn(API, 'postXpertSettings');

await waitFor(() => expect(container.querySelector('#enable-xpert-unit-summary-toggle')).toBeTruthy());
await waitFor(() => expect(container.querySelector('#enable-xpert_unit_summary-toggle')).toBeTruthy());
fireEvent.click(queryByTestId(container, 'reset-units'));
expect(API.postXpertSettings).toBeCalledWith(courseId, { reset: true, enabled: true });
});
Expand All @@ -274,7 +274,7 @@ describe('XpertUnitSummarySettings', () => {

jest.spyOn(API, 'postXpertSettings');

await waitFor(() => expect(container.querySelector('#enable-xpert-unit-summary-toggle')).toBeTruthy());
await waitFor(() => expect(container.querySelector('#enable-xpert_unit_summary-toggle')).toBeTruthy());
fireEvent.click(queryByTestId(container, 'reset-units'));
expect(API.postXpertSettings).toBeCalledWith(courseId, { reset: true, enabled: false });
});
Expand Down
2 changes: 1 addition & 1 deletion plugins/course-apps/xpert_unit_summary/appInfo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export default {
id: 'xpert-unit-summary',
id: 'xpert_unit_summary',
enabled: false,
name: 'Xpert unit summaries',
description: 'Use generative AI to summarize course content and reinforce learning.',
Expand Down
8 changes: 4 additions & 4 deletions plugins/course-apps/xpert_unit_summary/data/thunks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export function updateXpertSettings(courseId, state) {
const { response } = await postXpertSettings(courseId, state);
const { success } = response;
if (success) {
dispatch(updateModel({ modelType: 'XpertSettings', model: { id: 'xpert-unit-summary', enabled: state.enabled } }));
dispatch(updateModel({ modelType: 'XpertSettings', model: { id: 'xpert_unit_summary', enabled: state.enabled } }));
dispatch(updateSavingStatus({ status: RequestStatus.SUCCESSFUL }));
return true;
}
Expand All @@ -40,7 +40,7 @@ export function fetchXpertPluginConfigurable(courseId) {
dispatch(addModel({
modelType: 'XpertSettings.enabled',
model: {
id: 'xpert-unit-summary',
id: 'xpert_unit_summary',
enabled,
},
}));
Expand All @@ -62,7 +62,7 @@ export function fetchXpertSettings(courseId) {
dispatch(addModel({
modelType: 'XpertSettings',
model: {
id: 'xpert-unit-summary',
id: 'xpert_unit_summary',
enabled,
},
}));
Expand All @@ -79,7 +79,7 @@ export function removeXpertSettings(courseId) {
const { response } = await deleteXpertSettings(courseId);
const { success } = response;
if (success) {
const model = { id: 'xpert-unit-summary', enabled: undefined };
const model = { id: 'xpert_unit_summary', enabled: undefined };
dispatch(updateModel({ modelType: 'XpertSettings', model }));
dispatch(updateSavingStatus({ status: RequestStatus.SUCCESSFUL }));
return true;
Expand Down
Loading