Skip to content

feat: improved local translation handling #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deborahgu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: improved local translation handling #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dockerfiles/credentials.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@
FROM ubuntu:jammy AS base

ARG OPENEDX_TRANSLATIONS_REPO
ARG OPENEDX_ATLAS_EXTRA_SOURCES
ARG CREDENTIALS_SERVICE_REPO=edx/credentials
ARG CREDENTIALS_SERVICE_VERSION=master
ARG PYTHON_VERSION=3.12
ENV TZ=UTC
ENV TERM=xterm-256color
ENV DEBIAN_FRONTEND=noninteractive
ENV ATLAS_OPTIONS="--repository=$OPENEDX_TRANSLATIONS_REPO"
ENV ATLAS_EXTRA_SOURCES="--repository=$OPENEDX_ATLAS_EXTRA_SOURCES"

This comment was marked as spam.

Sign in to view


# software-properties-common is needed to setup our Python 3.12 env
RUN apt-get update && \
Expand Down Expand Up @@ -133,7 +135,10 @@ CMD gunicorn --workers=2 --name credentials -c /edx/app/credentials/credentials/
FROM base AS dev
USER root

ARG OPENEDX_ATLAS_EXTRA_SOURCES
ARG OPENEDX_TRANSLATIONS_REPO
ENV ATLAS_EXTRA_SOURCES="--repository=$OPENEDX_ATLAS_EXTRA_SOURCES"

This comment was marked as spam.

Sign in to view



RUN curl -L -o credentials/settings/devstack.py https://raw.githubusercontent.com/edx/devstack/${CREDENTIALS_SERVICE_VERSION}/py_configuration_files/credentials.py

Expand Down
2 changes: 2 additions & 0 deletions dockerfiles/edx-platform.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,8 +291,10 @@ RUN pip install -e .
# out the stage allows us to shed all of the unwanted out-of-repo changes.
FROM app-deps AS translations

ARG OPENEDX_ATLAS_EXTRA_SOURCES
ARG OPENEDX_TRANSLATIONS_VERSION
ARG OPENEDX_TRANSLATIONS_REPO
ENV ATLAS_EXTRA_SOURCES="--repository=$OPENEDX_ATLAS_EXTRA_SOURCES"

This comment was marked as spam.

Sign in to view


# Install translations files. Note that this leaves the git working directory in
# a "dirty" state.
Expand Down