Skip to content

feat: Implement deletion notification system for expired GDPR reports#60

Open
ttak-apphelix wants to merge 8 commits intomasterfrom
ttak-apphelix/BOMS-398-delete-notification
Open

feat: Implement deletion notification system for expired GDPR reports#60
ttak-apphelix wants to merge 8 commits intomasterfrom
ttak-apphelix/BOMS-398-delete-notification

Conversation

@ttak-apphelix
Copy link
Copy Markdown
Member

@ttak-apphelix ttak-apphelix commented Mar 5, 2026

Description:

Implements a Google Drive comment-based notification step intended to alert external partner contacts before GDPR partner report CSVs are deleted by the existing expiration cleanup script.

Copilot AI review requested due to automatic review settings March 5, 2026 08:20
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements a Google Drive comment-based notification step intended to alert external partner contacts before GDPR partner report CSVs are deleted by the existing expiration cleanup script.

Changes:

  • Added a deletion-notification message template and logic to post comments on soon-to-be-deleted report files.
  • Added partner-permission inspection to derive external email recipients (with denied-domain filtering) for notifications.
  • Hooked the notification pass into the delete_expired_reports command prior to deletion.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tubular/scripts/delete_expired_partner_gdpr_reports.py Outdated
Comment thread tubular/scripts/delete_expired_partner_gdpr_reports.py
Comment thread tubular/scripts/delete_expired_partner_gdpr_reports.py Outdated
Comment thread tubular/scripts/delete_expired_partner_gdpr_reports.py Outdated
Comment thread tubular/scripts/delete_expired_partner_gdpr_reports.py Outdated
Comment thread tubular/scripts/delete_expired_partner_gdpr_reports.py
Copilot AI review requested due to automatic review settings March 5, 2026 09:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tubular/scripts/delete_expired_partner_gdpr_reports.py Outdated
Comment thread tubular/scripts/delete_expired_partner_gdpr_reports.py
Comment thread tubular/scripts/delete_expired_partner_gdpr_reports.py
Comment thread tubular/tests/test_delete_expired_reports.py
Copilot AI review requested due to automatic review settings April 1, 2026 05:53
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tubular/scripts/delete_expired_partner_gdpr_reports.py Outdated
Comment thread tubular/scripts/delete_expired_partner_gdpr_reports.py Outdated
Comment thread tubular/tests/test_delete_expired_reports.py Outdated
Comment thread tubular/scripts/delete_expired_partner_gdpr_reports.py Outdated
@ttak-apphelix ttak-apphelix changed the title [DO NOT MERGE]feat: Implement deletion notification system for expired GDPR reports feat: Implement deletion notification system for expired GDPR reports Apr 1, 2026
Copilot AI review requested due to automatic review settings April 1, 2026 07:35
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tubular/scripts/delete_expired_partner_gdpr_reports.py
@ttak-apphelix ttak-apphelix requested a review from robrap April 10, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants