Skip to content

feat: update overdue notification to include calculated deletion date#66

Merged
ttak-apphelix merged 1 commit intomasterfrom
ttak-apphelix/BOMS-398-2
Apr 14, 2026
Merged

feat: update overdue notification to include calculated deletion date#66
ttak-apphelix merged 1 commit intomasterfrom
ttak-apphelix/BOMS-398-2

Conversation

@ttak-apphelix
Copy link
Copy Markdown
Member

@ttak-apphelix ttak-apphelix commented Apr 14, 2026

Decsription:

Updates overdue deletion-warning notifications in the partner retirement report workflow to include a deletion date that matches the “days until deletion” messaging.

Changes:

Compute an overdue_deletion_date for overdue files based on now + warning_days.
Use the computed overdue deletion date in the deletion warning template instead of the original (already-passed) retention-based deletion date.

JIRA ticket:
https://2u-internal.atlassian.net/browse/BOMS-398

Copilot AI review requested due to automatic review settings April 14, 2026 10:14
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates overdue deletion-warning notifications in the partner retirement report workflow to include a deletion date that matches the “days until deletion” messaging.

Changes:

  • Compute an overdue_deletion_date for overdue files based on now + warning_days.
  • Use the computed overdue deletion date in the deletion warning template instead of the original (already-passed) retention-based deletion date.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tubular/scripts/retirement_partner_report.py
Comment thread tubular/scripts/retirement_partner_report.py
@ttak-apphelix ttak-apphelix merged commit 2d80bdc into master Apr 14, 2026
7 checks passed
@ttak-apphelix ttak-apphelix deleted the ttak-apphelix/BOMS-398-2 branch April 14, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants