Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Showed all property in View page #200

Open
wants to merge 7 commits into
base: module-upgrade
Choose a base branch
from
Open

Showed all property in View page #200

wants to merge 7 commits into from

Conversation

mukund-egov
Copy link
Collaborator

No description provided.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

jagankumar-egov
jagankumar-egov requested changes Mar 6, 2025
View reviewed changes
frontend/new-micro-ui/web/micro-ui-internals/packages/modules/tl/src/hooks/services/Search.js Outdated
};

/* methid to get date from epoch */
const convertEpochToDate = (dateEpoch) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukund-egov @Kamalesh-egov
if this is a common function it should nt be duplicated in search
create a util in this module use the util here.

frontend/new-micro-ui/web/micro-ui-internals/packages/modules/tl/src/hooks/services/Search.js Outdated
return null;
}
};
const getAddress = (address, t) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here as well
@mukund-egov @Kamalesh-egov
if this is a common function it should nt be duplicated in search
create a util in this module use the util here.

frontend/new-micro-ui/web/micro-ui-internals/packages/modules/tl/src/hooks/services/Search.js Outdated
};
export const TLSearch = {
all: async (tenantId, filters = {}) => {
const response = await Digit.CustomService.getResponse({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why custom service integration and why it is repeated again and again

frontend/new-micro-ui/web/micro-ui-internals/packages/modules/tl/src/hooks/services/Search.js Outdated

applicationDetails: async (t, tenantId, applicationNumber, userType) => {
const filter = { applicationNumber };
const response = await TLSearch.application(tenantId, filter);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use direct call here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagankumar-egov jagankumar-egov jagankumar-egov requested changes

@vinothrallapalli-eGov vinothrallapalli-eGov Awaiting requested review from vinothrallapalli-eGov vinothrallapalli-eGov is a code owner

@kavi-egov kavi-egov Awaiting requested review from kavi-egov kavi-egov is a code owner

@pradeepkumarcm-egov pradeepkumarcm-egov Awaiting requested review from pradeepkumarcm-egov pradeepkumarcm-egov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mukund-egov @jagankumar-egov