Skip to content

fastest_pkg.py: HTTPS#7

Draft
grahamperrin wants to merge 1 commit into
ehaupt:masterfrom
grahamperrin:patch-1
Draft

fastest_pkg.py: HTTPS#7
grahamperrin wants to merge 1 commit into
ehaupt:masterfrom
grahamperrin:patch-1

Conversation

@grahamperrin

@grahamperrin grahamperrin commented Sep 15, 2023

Copy link
Copy Markdown

Towards consistency with pkg: use https by default · freebsd/freebsd-src@d557a86

d557a86c879a pkg: use https by default

From https://reviews.freebsd.org/D40473:

… base is providing a CA root bundle suitable to validate the certificates used by the project. …

Cross-reference: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273833

Towards consistency with
freebsd/freebsd-src@d557a86

d557a86c879a pkg: use https by default
@grahamperrin

Copy link
Copy Markdown
Author

In addition, will changes to lines 87 and 89 be appropriate? In ehaupt:master:

try:
pkg_mirrors = resolver.resolve("_http._tcp.pkg.all.freebsd.org", "SRV")
except AttributeError:
pkg_mirrors = resolver.query("_http._tcp.pkg.all.freebsd.org", "SRV")

More generally, I guess that a change to HTTPS should not be made until the bundle becomes broadly available to end users.

@ehaupt

ehaupt commented Oct 2, 2023

Copy link
Copy Markdown
Owner

When using HTTPS the SRV query should probably be adjusted even though the list is currently identical apart from the port (which is not used in the script).

$ dig +short -t srv _http._tcp.pkg.all.freebsd.org
50 10 80 pkg0.bbt.freebsd.org.
50 10 80 pkg0.bme.freebsd.org.
50 10 80 pkg0.bra.freebsd.org.
50 10 80 pkg0.fra.freebsd.org.
50 10 80 pkg0.isc.freebsd.org.
50 10 80 pkg0.kul.freebsd.org.
50 10 80 pkg0.kwc.freebsd.org.
50 10 80 pkg0.nyi.freebsd.org.
50 10 80 pkg0.tuk.freebsd.org.
50 10 80 pkg0.twn.freebsd.org.
50 10 80 pkg0.jinx.freebsd.org.

$ dig +short -t srv _https._tcp.pkg.all.freebsd.org
50 10 443 pkg0.bbt.freebsd.org.
50 10 443 pkg0.bme.freebsd.org.
50 10 443 pkg0.bra.freebsd.org.
50 10 443 pkg0.fra.freebsd.org.
50 10 443 pkg0.isc.freebsd.org.
50 10 443 pkg0.kul.freebsd.org.
50 10 443 pkg0.kwc.freebsd.org.
50 10 443 pkg0.nyi.freebsd.org.
50 10 443 pkg0.tuk.freebsd.org.
50 10 443 pkg0.twn.freebsd.org.
50 10 443 pkg0.jinx.freebsd.org.

I am in favor of introducing a command line option for disabling HTTPS but use it by default. Maybe --disable-ssl. Thoughts?

@grahamperrin

Copy link
Copy Markdown
Author

Thoughts?

Thinking … if you become impatient, after a few days or weeks, nudge me :)

@grahamperrin

Copy link
Copy Markdown
Author

after a few days or weeks,

or years, LOL!

I think, please do whatever pleases you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants