Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JANA2-related deprecation warnings and TODOs #1622

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix JANA2-related deprecation warnings and TODOs #1622

wants to merge 3 commits into from
+8 −14

Commits on Sep 21, 2024

  1. Migrate away from JFactorySet::GetFactory<T>() 

    This will be going away in a future release. JFactorySet won't have any dependency on JFactoryT (and neither will Podio factories) and won't have any template methods.
    @nathanwbrei
    nathanwbrei committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    8efe3a1 View commit details
    Browse the repository at this point in the history

  2. Migrate away from old JParameterManager::PrintParameters() 

    This is already deprecated and emits a bunch of warnings during compilation.
    @nathanwbrei
    nathanwbrei committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    0367bba View commit details
    Browse the repository at this point in the history

  3. Remove old TODO: NWB comments 

    These reflect past issues with JANA2, not EICrecon. They have been addressed there.
    @nathanwbrei
    nathanwbrei committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    93f054b View commit details
    Browse the repository at this point in the history