FEMCal photon count for ScFI #2190
Open
+14
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding switch between Homogeneous and ScFi geometry implementations based on xml file loaded - For Homogenous, we keep enrgy smeasring as is. SF=1.0 - For ScFi, hits from fibers are summed to a tower and no enrgy smearing applied. SF=0.03. Added option to put SiPM saturation to CalorimeterHitDigi - Specify 2 new parameters : totalPixel and nPhotonPerGeV - default for totalPixel is 0, which case no attenuation is applied For FEMC for both geometry models, SiPM saturation is ON by default - Use "-PFEMC:SiPMSaturation=OFF" to turn it off
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… to Homogeneous model (see https://www.star.bnl.gov/~akio/epic/reco/index.html) - Adding ScFi model's resolution smearing of 2.2% constant term based on high energy end (see https://www.star.bnl.gov/~akio/epic/reco/index.html) - Changing ADC threshold from 2 (~9MeV which was too low) to 3 (~15MeV as intended) - Rename an unfortunate variable name
for more information, see https://pre-commit.ci
Co-authored-by: Dmitry Kalinkin <[email protected]>
Co-authored-by: Dmitry Kalinkin <[email protected]>
Co-authored-by: Dmitry Kalinkin <[email protected]>
for more information, see https://pre-commit.ci
Updated sampling fraction and formatting for configuration parameters.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
/home/runner/work/EICrecon/EICrecon/src/detectors/FEMC/FEMC.cc:105:39: note: insert an explicit cast to silence this issue
105 | .numEffectiveSipmPixels = totalPixel},
| ^~~~~~~~~~
| static_cast<unsigned long long>( )
for more information, see https://pre-commit.ci
Contributor
Contributor
Author
|
Also applying resolution smearing (1.0 + eResRel) factor should be before SiPM saturation. I thought we talked about it? Cannot recall maybe you rejected for a reason. At least for FEMC, edep should be modifyed by (1.0 + eResRel) factor, then go through all photon statistics and SiPM sauration. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
veprbl
reviewed
Nov 18, 2025
This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/19474751836. Please merge this PR into the branch `fEMCal_photon_count` to resolve failures in PR #2190. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/19505021244. Please merge this PR into the branch `fEMCal_photon_count` to resolve failures in PR #2190. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
dismissed
their stale review
No Clang-Tidy warnings found so I assume my comments were addressed
for more information, see https://pre-commit.ci
This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/19508711009. Please merge this PR into the branch `fEMCal_photon_count` to resolve failures in PR #2190. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
veprbl
reviewed
Nov 26, 2025
akioogawa
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Fix photon count inconsistency for ScFI
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
No