fix(ci): don't use pre-filled JANA_PLUGIN_PATH with EICrecon plugins #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will avoid mistakes like https://github.com/eic/EICrecon/actions/runs/6137527478/job/16653814205?pr=940#step:5:126 sneaking through without failures. |
9 tasks
wdconinc
temporarily deployed
to
github-pages
GitHub Actions
Inactive
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
### Briefly, what does this PR introduce? Allow to create shared instead of static algorithms libraries, and allow skipping the creation of an algorithms plugin. Depends on: - [x] #942 (cherry-picked) - [x] #938 (cherry-picked) ### What kind of change does this PR introduce? - [x] Bug fix (issue #628 again) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
JANA_PLUGIN_PATHin eic-shell (and therefore CI environments) is prepopulated with/usr/local/lib/EICrecon/plugins:/usr/local/plugins. This means that removing (intentionally or otherwise) a plugin in a PR will still cause it to be found in/usr/local/lib/EICrecon/plugins. We need/usr/local/pluginsthough, because that contains thejanadotplugin to create callgraphs.There's an issue reported to JANA2 (JeffersonLab/JANA2#136) that points out that installing plugins in a shared namespace at
/usr/local/pluginsmay lead to issues and does not conform to the linux FHS. But at least EICrecon plugins are not installed there, otherwise we would have exactly this issue.What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.