Support arbitrary cross-section shapes in beamline benchmark overlays #224
+150
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beamline acceptance and steering plots only overlaid circles for pipe cross-sections, failing to visualize non-ConeSegment intersection solids.
Changes
Shape extraction (
shared_functions.h): AddedextractShapeOutline()to extract boundary points from arbitrary TGeo shapes via polar sampling with binary search onTGeoShape::Contains()Shape rendering: Added
drawShapeOutline()using TPolyLine for arbitrary polygonal cross-sectionsAnalysis updates: Modified
acceptanceAnalysis.CandbeamlineAnalysis.Cto conditionally render circles for ConeSegments or arbitrary outlines for other shapesImplementation
The
volParamsstruct now carries shape outlines:Drawing logic checks shape type:
ConeSegments continue using circles; all other shapes render their actual cross-section geometry.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.