Skip to content

Improve settings UX and tests#1484

Open
kiannidev wants to merge 5 commits intoeigent-ai:mainfrom
kiannidev:improve-settings-ux-and-tests
Open

Improve settings UX and tests#1484
kiannidev wants to merge 5 commits intoeigent-ai:mainfrom
kiannidev:improve-settings-ux-and-tests

Conversation

@kiannidev
Copy link
Copy Markdown
Contributor

@kiannidev kiannidev commented Mar 11, 2026

Summary

  • Enhance Privacy settings page with proper loading, error handling, and optimistic toggle for 'Help improve Eigent'.
  • Improve General settings Network Proxy UX with helper copy, change detection, and restart flow.
  • Add unit tests for Privacy and General settings pages to cover loading, validation, and save behavior.

@kiannidev kiannidev force-pushed the improve-settings-ux-and-tests branch from 58aedae to 4a2b260 Compare March 11, 2026 17:49
@4pmtong 4pmtong requested a review from a7m-1st March 16, 2026 06:54
@4pmtong
Copy link
Copy Markdown
Collaborator

4pmtong commented Mar 16, 2026

Thanks @kiannidev for contribution! could @a7m-1st help review it?

@bytecii
Copy link
Copy Markdown
Collaborator

bytecii commented Mar 19, 2026

Can you give a screenshot for your UI changes?

@kiannidev
Copy link
Copy Markdown
Contributor Author

kiannidev commented Mar 19, 2026

image Thanks for the review @bytecii . This PR primarily improves **settings behavior and reliability**, so visual UI changes are intentionally minimal.

What changed visually

  • General → Network Proxy: added a small helper text line explaining proxy behavior.
  • General → Network Proxy: improved button states:
    • Save is disabled until the value is changed.
    • After save, action changes to Restart to Apply.

What changed functionally (main scope)

  • Privacy setting toggle now has stronger loading/save handling and rollback on save failure.
  • Improved error handling for privacy/proxy fetch and save failures.
  • Added broader unit test coverage for Privacy and General proxy flows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants