fix: add iputils-ping to CI container for verify_port_forwarding#557
Closed
claude-claude[bot] wants to merge 1 commit intofix-pasta-restore-probefrom
Closed
fix: add iputils-ping to CI container for verify_port_forwarding#557claude-claude[bot] wants to merge 1 commit intofix-pasta-restore-probefrom
claude-claude[bot] wants to merge 1 commit intofix-pasta-restore-probefrom
Conversation
The verify_port_forwarding() method was changed from using `ip neigh show` to using `ping` to actively trigger ARP resolution after snapshot restore. However, `iputils-ping` was only added to Containerfile.nested, not to the main Containerfile used for Container-x64 and Container-arm64 CI tests. Without `ping` available, nsenter fails with a non-zero exit code on every attempt, causing verify_port_forwarding to always time out after 5s with: "ARP for guest 10.0.2.100 not resolved within 5s on br0" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
Closing: fix already incorporated in PR #555. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Fix
Fixes CI #22654795098
Problem
The
verify_port_forwarding()method was changed (in commit 139f095) from usingip neigh showto usingpingto actively trigger ARP resolution after snapshot restore. However,iputils-pingwas only added toContainerfile.nested(commit 874f891), not to the mainContainerfileused for Container-x64 and Container-arm64 CI tests.The
rust:1.83-bookwormbase image does not includeping. Without it,nsenter ... pingfails with a non-zero exit code on every attempt, causingverify_port_forwardingto always time out after 5s with:This caused both
test_clone_port_forward_stress_rootlessandtest_clone_port_forward_rootlessto fail consistently in container CI environments (x64 and arm64).Solution
Add
iputils-pingto the mainContainerfilepackage list, matching what was already done forContainerfile.nested.Note on Host-Root stress test failures
The Host-Root-arm64
test_clone_port_forward_stress_rootlessfailures ("Connection reset by peer") are a separate issue — the underlying pasta connection poisoning bug that this PR branch is investigating. On host tests,pingis available and ARP resolves fine, but the actual port forwarding still fails under concurrent clone stress. This is the pre-existing bug, not a regression from this change.Generated by Claude | Fix Run