Better acks, better chunk inserts & larger buffers #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietdevaere
commented
Oct 28, 2017
| } | ||
| } | ||
|
|
||
| if ok && pk.acked2 { | ||
| delete(p.packets, pn) |
There was a problem hiding this comment.
I'm deleting this because I see no more use for use for storing this data. @ekr, can you confirm that this is the case, or is there something I am forgetting?
|
I wanted to acknowledge receipt of this. I have to do Internet Drafts between now and Monday, so I won't be able to look till next week, but I will do so then. |
pietdevaere
changed the title
|
I have tacked on an improvement to |
When selecting the number of frames and acks to be transmitted, the header size and AEAD overhead were not considered when determining the space left in the packet.
Problem was that it was decied to generate an ack frame BEFORE it was known that there was space to put acks in the packet. This resulted in an empty rs slice, causing errors
should now be able to handle ack rangesx
This reverts commit f5d96d2.
pietdevaere
force-pushed
the
buffer_ack_optimization_PR
branch
from
3454452 to
f9bb6f2
Compare
When selecting the number of frames and acks to be transmitted, the header size and AEAD overhead were not considered when determining the space left in the packet.
Problem was that it was decied to generate an ack frame BEFORE it was known that there was space to put acks in the packet. This resulted in an empty rs slice, causing errors
should now be able to handle ack rangesx
This reverts commit f5d96d2.
Closed
|
Now included in #37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents ACK generation processing from exploding to solve #29 , and increases UDP buffers in size to solve #32.
This PR is build on top of #30