-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "My series" page #1311
Add "My series" page #1311
Conversation
0d8826c
to
7b97115
Compare
40bae15
to
7a054e4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
7768227
to
2582293
Compare
This comment was marked as outdated.
This comment was marked as outdated.
2582293
to
46c24bc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
46c24bc
to
53908b1
Compare
b6b8bca
to
8d766f6
Compare
8d766f6
to
1e32aed
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This combines two things: (a) It fixes the event query for the `My videos` table. Adjumstments became necessary after some upstream changes to the series column in the `from_db` impl of authorized events. (b) It moves some table specific query customizations from the generic `load_writable_for_user` function to the impls of the `LoadableAsset` trait.
I forgot the fact that the table might include events that have been marked as deleted. Unfortunately that means the query and `LoadableAsset` trait are getting increasingly complicated to the point where it's hard to understand and quite easy to make these errors. This is also in part due to the series table's need to be sortable by event count, and I am starting to wonder if it might be better to move the whole query to the trait, though that brings its own complications and I doubt that would even be possible without other major adjustments.
618ba48
to
14da37c
Compare
I didn't like the name.
It did not need to be so complicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a review of the backend code. And while I left quite a lot of inline comments, I am actually very happy with that! The approach is sane and you used Rust features cleverly, even wrote a macro! Most of my comments just refer to minor things one can write in a shorter way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, here is a review of the frontend. I didn't test it in detail yet, but from what I saw, I like it. Looks good.
4d08990
to
84861ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all changes again, much improved. Still some comments but nothing complicated I think.
84861ab
to
bd91318
Compare
bd91318
to
bda0b42
Compare
Just some refactoring, but which slightly changes the API in an insignificant way.
I change the `myFoo` functions in a way to allow the `mySeries` one to fetch the thumbnail info already. This results in two new API fields that is used by the "my series" page to gather all necessary info without causing an 1+n query problem.
Solve 1+n query problem
This adds a page to the "manage pages" area were users can see a list of their series.
Most of these changes are related to generalizing the "My videos" backend and frontend code, so it can also be used for series-, and later on playlist management.
This PR also addresses two issues related to the "My videos" table.
Please note that this is only the first step in adding a proper series management in Tobira. Right now, the list entries link directly to the corresponding series. This will be changed later to link to a "Series details" page.
Note for the reviewer: This is probably better to review file-by-file, since a lot of the commits touch and revise the same files.
Part of #355
Fixes #759
Closes #527