Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "My series" page #1311

Merged
merged 21 commits into from
Feb 24, 2025
Merged

Add "My series" page #1311

merged 21 commits into from
Feb 24, 2025

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Jan 9, 2025

This adds a page to the "manage pages" area were users can see a list of their series.
Most of these changes are related to generalizing the "My videos" backend and frontend code, so it can also be used for series-, and later on playlist management.

This PR also addresses two issues related to the "My videos" table.

Please note that this is only the first step in adding a proper series management in Tobira. Right now, the list entries link directly to the corresponding series. This will be changed later to link to a "Series details" page.

Note for the reviewer: This is probably better to review file-by-file, since a lot of the commits touch and revise the same files.

Part of #355
Fixes #759
Closes #527

@owi92 owi92 added the changelog:user User facing changes label Jan 9, 2025
@github-actions github-actions bot temporarily deployed to test-deployment-pr1311 January 9, 2025 14:04 Destroyed
@owi92 owi92 force-pushed the series-management branch from 0d8826c to 7b97115 Compare January 10, 2025 14:58
@github-actions github-actions bot temporarily deployed to test-deployment-pr1311 January 10, 2025 15:03 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr1311 January 13, 2025 09:57 Destroyed
@owi92 owi92 force-pushed the series-management branch from 40bae15 to 7a054e4 Compare January 13, 2025 10:31
@github-actions github-actions bot temporarily deployed to test-deployment-pr1311 January 13, 2025 10:34 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr1311 January 13, 2025 13:35 Destroyed
@owi92 owi92 mentioned this pull request Jan 15, 2025
9 tasks
@github-actions github-actions bot added the status:conflicts This PR has conflicts that need to be resolved label Jan 17, 2025

This comment was marked as outdated.

@owi92 owi92 force-pushed the series-management branch from 7768227 to 2582293 Compare January 20, 2025 10:05
@github-actions github-actions bot removed the status:conflicts This PR has conflicts that need to be resolved label Jan 20, 2025
@github-actions github-actions bot temporarily deployed to test-deployment-pr1311 January 20, 2025 10:08 Destroyed
@github-actions github-actions bot added the status:conflicts This PR has conflicts that need to be resolved label Jan 20, 2025

This comment was marked as outdated.

@owi92 owi92 force-pushed the series-management branch from 2582293 to 46c24bc Compare January 20, 2025 11:41
@github-actions github-actions bot removed the status:conflicts This PR has conflicts that need to be resolved label Jan 20, 2025
@github-actions github-actions bot temporarily deployed to test-deployment-pr1311 January 20, 2025 11:44 Destroyed
@github-actions github-actions bot added the status:conflicts This PR has conflicts that need to be resolved label Jan 27, 2025

This comment was marked as outdated.

@owi92 owi92 force-pushed the series-management branch from 46c24bc to 53908b1 Compare January 27, 2025 16:21
@github-actions github-actions bot removed the status:conflicts This PR has conflicts that need to be resolved label Jan 27, 2025
@github-actions github-actions bot temporarily deployed to test-deployment-pr1311 January 27, 2025 16:24 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr1311 January 27, 2025 18:10 Destroyed
@owi92 owi92 force-pushed the series-management branch from b6b8bca to 8d766f6 Compare January 27, 2025 21:31
@github-actions github-actions bot temporarily deployed to test-deployment-pr1311 January 27, 2025 21:33 Destroyed
@owi92 owi92 force-pushed the series-management branch from 8d766f6 to 1e32aed Compare January 27, 2025 21:34
@github-actions github-actions bot added the status:conflicts This PR has conflicts that need to be resolved label Feb 4, 2025

This comment was marked as outdated.

owi92 added 3 commits February 6, 2025 17:23
This combines two things:
(a) It fixes the event query for the `My videos` table.
    Adjumstments became necessary after some upstream
    changes to the series column in the `from_db` impl
    of authorized events.
(b) It moves some table specific query customizations
    from the generic `load_writable_for_user` function
    to the impls of the `LoadableAsset` trait.
I forgot the fact that the table might include events that
have been marked as deleted. Unfortunately that means the
query and `LoadableAsset` trait are getting increasingly
complicated to the point where it's hard to understand and
quite easy to make these errors.
This is also in part due to the series table's need to be
sortable by event count, and I am starting to wonder if it
might be better to move the whole query to the trait, though
that brings its own complications and I doubt that would even
be possible without other major adjustments.
@owi92 owi92 force-pushed the series-management branch from 618ba48 to 14da37c Compare February 6, 2025 16:23
@github-actions github-actions bot temporarily deployed to test-deployment-pr1311 February 6, 2025 16:26 Destroyed
owi92 added 2 commits February 9, 2025 17:17
I didn't like the name.
It did not need to be so complicated.
@github-actions github-actions bot temporarily deployed to test-deployment-pr1311 February 10, 2025 09:44 Destroyed
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a review of the backend code. And while I left quite a lot of inline comments, I am actually very happy with that! The approach is sane and you used Rust features cleverly, even wrote a macro! Most of my comments just refer to minor things one can write in a shorter way.

Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, here is a review of the frontend. I didn't test it in detail yet, but from what I saw, I like it. Looks good.

@github-actions github-actions bot temporarily deployed to test-deployment-pr1311 February 17, 2025 09:47 Destroyed
@owi92 owi92 force-pushed the series-management branch from 4d08990 to 84861ab Compare February 18, 2025 11:24
@github-actions github-actions bot temporarily deployed to test-deployment-pr1311 February 18, 2025 11:29 Destroyed
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all changes again, much improved. Still some comments but nothing complicated I think.

@owi92 owi92 force-pushed the series-management branch from 84861ab to bd91318 Compare February 20, 2025 13:54
@github-actions github-actions bot temporarily deployed to test-deployment-pr1311 February 20, 2025 13:58 Destroyed
@owi92 owi92 force-pushed the series-management branch from bd91318 to bda0b42 Compare February 20, 2025 15:13
@github-actions github-actions bot temporarily deployed to test-deployment-pr1311 February 20, 2025 15:16 Destroyed
LukasKalbertodt and others added 6 commits February 21, 2025 15:08
Just some refactoring, but which slightly changes the API in an
insignificant way.
I change the `myFoo` functions in a way to allow the `mySeries` one
to fetch the thumbnail info already. This results in two new API fields
that is used by the "my series" page to gather all necessary info
without causing an 1+n query problem.
@github-actions github-actions bot temporarily deployed to test-deployment-pr1311 February 24, 2025 12:35 Destroyed
@LukasKalbertodt LukasKalbertodt merged commit a0c93b2 into elan-ev:next Feb 24, 2025
4 checks passed
@owi92 owi92 deleted the series-management branch March 3, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:user User facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants