Add "My series" page #1311
Merged
Add "My series" page #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owi92
force-pushed
the
series-management
branch
from
0d8826c to
7b97115
Compare
owi92
force-pushed
the
series-management
branch
from
40bae15 to
7a054e4
Compare
github-actions
bot
added
the
status:conflicts
This comment was marked as outdated.
This comment was marked as outdated.
owi92
force-pushed
the
series-management
branch
from
7768227 to
2582293
Compare
github-actions
bot
removed
the
status:conflicts
github-actions
bot
added
the
status:conflicts
This comment was marked as outdated.
This comment was marked as outdated.
owi92
force-pushed
the
series-management
branch
from
2582293 to
46c24bc
Compare
github-actions
bot
removed
the
status:conflicts
github-actions
bot
added
the
status:conflicts
This comment was marked as outdated.
This comment was marked as outdated.
owi92
force-pushed
the
series-management
branch
from
46c24bc to
53908b1
Compare
github-actions
bot
removed
the
status:conflicts
owi92
force-pushed
the
series-management
branch
from
b6b8bca to
8d766f6
Compare
owi92
force-pushed
the
series-management
branch
from
8d766f6 to
1e32aed
Compare
github-actions
bot
added
the
status:conflicts
This comment was marked as outdated.
This comment was marked as outdated.
This combines two things:
(a) It fixes the event query for the `My videos` table.
Adjumstments became necessary after some upstream
changes to the series column in the `from_db` impl
of authorized events.
(b) It moves some table specific query customizations
from the generic `load_writable_for_user` function
to the impls of the `LoadableAsset` trait.
I forgot the fact that the table might include events that have been marked as deleted. Unfortunately that means the query and `LoadableAsset` trait are getting increasingly complicated to the point where it's hard to understand and quite easy to make these errors. This is also in part due to the series table's need to be sortable by event count, and I am starting to wonder if it might be better to move the whole query to the trait, though that brings its own complications and I doubt that would even be possible without other major adjustments.
owi92
force-pushed
the
series-management
branch
from
618ba48 to
14da37c
Compare
I didn't like the name.
It did not need to be so complicated.
LukasKalbertodt
requested changes
Feb 12, 2025
There was a problem hiding this comment.
This is just a review of the backend code. And while I left quite a lot of inline comments, I am actually very happy with that! The approach is sane and you used Rust features cleverly, even wrote a macro! Most of my comments just refer to minor things one can write in a shorter way.
LukasKalbertodt
requested changes
Feb 12, 2025
owi92
force-pushed
the
series-management
branch
from
4d08990 to
84861ab
Compare
LukasKalbertodt
requested changes
Feb 20, 2025
owi92
force-pushed
the
series-management
branch
from
84861ab to
bd91318
Compare
owi92
force-pushed
the
series-management
branch
from
bd91318 to
bda0b42
Compare
Just some refactoring, but which slightly changes the API in an insignificant way.
I change the `myFoo` functions in a way to allow the `mySeries` one to fetch the thumbnail info already. This results in two new API fields that is used by the "my series" page to gather all necessary info without causing an 1+n query problem.
Solve 1+n query problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a page to the "manage pages" area were users can see a list of their series.
Most of these changes are related to generalizing the "My videos" backend and frontend code, so it can also be used for series-, and later on playlist management.
This PR also addresses two issues related to the "My videos" table.
Please note that this is only the first step in adding a proper series management in Tobira. Right now, the list entries link directly to the corresponding series. This will be changed later to link to a "Series details" page.
Note for the reviewer: This is probably better to review file-by-file, since a lot of the commits touch and revise the same files.
Part of #355
Fixes #759
Closes #527