Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Fully remove Enterprise Search from Metricbeat #42915

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

markjhoy
Copy link

@markjhoy markjhoy commented Feb 26, 2025

As Enterprise Search will no longer be in 9.x, this PR removes the Enterprise Search module from Metricbeat.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

The Enterprise Search module will be removed for 9.x. As Enterprise Search is not in the 9.x stack, no disruptions may happen, however it is noteworthy to call this out.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 26, 2025
Copy link
Contributor

mergify bot commented Feb 26, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @markjhoy? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@markjhoy markjhoy added Team:Search Search Team (formerly Enterprise Search) backport-9.0 Automated backport to the 9.0 branch labels Feb 26, 2025
@@ -44,9 +44,6 @@ const (

// Beats product
Beats

// Enterprise Search product
EnterpriseSearch
)

func (p Product) xPackMonitoringIndexString() string {
Copy link
Contributor

@consulthys consulthys Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markjhoy in this function "ent-search" also needs to be removed from the indexProductNames array

@markjhoy markjhoy removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 27, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 27, 2025
Copy link
Contributor

mergify bot commented Feb 27, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b markjhoy/remove_ent_search_metricbeat_module upstream/markjhoy/remove_ent_search_metricbeat_module
git merge upstream/main
git push upstream markjhoy/remove_ent_search_metricbeat_module

@markjhoy markjhoy marked this pull request as ready for review February 27, 2025 21:36
@markjhoy markjhoy requested review from a team as code owners February 27, 2025 21:36
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the data-plane parts

@leehinman leehinman added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Feb 27, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-9.0 Automated backport to the 9.0 branch deprecation Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Search Search Team (formerly Enterprise Search)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants