update snyk branch monitoring in bump-version workflow #2998
+33
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @orouz? 🙏
|
orouz
commented
Feb 11, 2025
| @@ -33,6 +32,7 @@ jobs: | |||
| with: | |||
| ref: ${{ github.ref_name }} | |||
| token: ${{ secrets.CLOUDSEC_MACHINE_TOKEN }} | |||
| fetch-depth: 0 | |||
There was a problem hiding this comment.
needed to get all branches as we'll be extracting the latest_major_latest_minor and previous_major_latest_minor
orouz
commented
Feb 11, 2025
Comment on lines
+221
to
+231
| branches=$(git branch -r | grep -Eo '[0-9]+\.[0-9]+' | sort -V | uniq) | ||
| # shellcheck disable=SC2128 | ||
| latest_major=$(echo "$branches" | cut -d. -f1 | uniq | tail -1) | ||
| # shellcheck disable=SC2128 | ||
| previous_major=$(echo "$branches" | cut -d. -f1 | uniq | tail -2 | head -1) | ||
| # shellcheck disable=SC2128 | ||
| latest_major_latest_minor=$(echo "$branches" | grep -E "^$latest_major\." | tail -1) | ||
| # shellcheck disable=SC2128 | ||
| previous_major_latest_minor=$(echo "$branches" | grep -E "^$previous_major\." | tail -1) | ||
| echo "latest_major_latest_minor: $latest_major_latest_minor" | ||
| echo "previous_major_latest_minor: $previous_major_latest_minor" |
There was a problem hiding this comment.
- this assumes the workflow is ran after the release branch were created (will fail before this runs if they aren't)
- copy-paste the lines to test on remote and remove
-rto test locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your changes
the bump-version workflow includes a part where we import the required branches to be scanned by snyk. this PR includes a fix to make it work regardless of the base branch the workflow is executed from.
(the issue is that snyk import api is limited and we're deleting the previous import and adding it again, not updating, so currently we're overriding. this is what is being fixed here)
example run
Related Issues