Skip to content

Feat/markdown#434

Closed
sketchybinary wants to merge 3 commits into
elastic:mainfrom
sketchybinary:feat/markdown
Closed

Feat/markdown#434
sketchybinary wants to merge 3 commits into
elastic:mainfrom
sketchybinary:feat/markdown

Conversation

@sketchybinary

Copy link
Copy Markdown

Closes https://github.com/elastic/crawler/issues/###

Checklists

Pre-Review Checklist

  • This PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check crawler.yml.example and elasticsearch.yml.example)
  • This PR has a meaningful title
  • This PR links to all relevant GitHub issues that it fixes or partially addresses
    • If there is no GitHub issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v0.1.0)
  • Considered corresponding documentation changes
  • Contributed any configuration settings changes to the configuration reference
  • Ran make notice if any dependencies have been added

Changes Requiring Extra Attention

  • Security-related changes (encryption, TLS, SSRF, etc)
  • New external service dependencies added.

Related Pull Requests

Release Note

sketchybinary and others added 3 commits April 30, 2026 22:35
This commit polishes the markdown extraction functionality by:
- Resolving all Rubocop linting errors in the markdown converter and associated tests.
- Fixing test failures in coordinator_spec.rb and elasticsearch_spec.rb.
- Removing unnecessary AI-generated comments mentioning gemini-cli.

Co-authored-by: sketchybinary <50390357+sketchybinary@users.noreply.github.com>
@sketchybinary sketchybinary requested a review from a team as a code owner May 1, 2026 11:29
@cla-checker-service

Copy link
Copy Markdown

❌ Author of the following commits did not sign a Contributor Agreement:
09754c7, bbcf923, 54c676c

Please, read and sign the above mentioned agreement if you want to contribute to this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant