-
Notifications
You must be signed in to change notification settings - Fork 14
Update assembler.yml to add EDOT docs #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@bmorelli25 @Mpdreamz This adds the EDOT docs to the Reference section, first level, as agreed (I believe). I'd like to get both of your approvals before moving forward. The sooner we get the existing docs live, the better, but we can decide when to do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM are we good on the path_prefix
being /reference/edot
I personally think /reference/opentelemetry
is better ?
Co-authored-by: Martijn Laarman <[email protected]>
![]() @KOTungseth @shainaraskas I wonder if we need a That way we can nest That way the navigation would be
Which will allow us to perhaps nest ECS/Semantic Conventions and other As suppose to having EDOTs as top level. |
That's interesting. For context:
In any case, given the strategic importance of OTel, I'd rather have it as a first level item in the Reference nav. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment on PR.
I am still advocating for E.g |
Good point, yes. If we don't mind OpenTelemetry having only a child for now, then I'd say to go for it! Edit: (I don't know if I should edit the navigation and assembler files differently in that case.) |
I don't know enough about the OTel roadmap to know if we need to make room for nesting. However, if the URLs wouldn't be impacted, we could also just nest it when we have other stuff to talk about, so we don't have an empty overview page and only one child in the short term. |
They would be, since I'm happy to asssume all |
I can think of several things we could host under OpenTelemetry that are not EDOT:
@bmorelli25 May I go ahead and merge? |
Are we ready to implement the redirects from the old GitHub pages docs to these new docs? In my opinion, we should do both things as close together as possible to prevent user confusion around which docs to look at. I'm not sure if that's a blocker, though. |
Shouldn't be much of a blocker in the sense that having the good links live would help us implement and test the remaining redirects in a short time frame, but I agree with you that these should happen close, and with EAH going on that's not possible. So I'm putting this one on hold while I open the redirects PR for the old docs and possibly a PR for Kibana links (if any). |
Adding
opentelemetry
to the assembly list.