Skip to content

Bump global.json version #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/bootstrap/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ runs:
git tag --list
- uses: actions/setup-dotnet@v4
with:
dotnet-version: 9.0.100
global-json-file: global.json

- id: dotnet
Expand All @@ -37,4 +38,3 @@ runs:
cache: npm
cache-dependency-path: src/Elastic.Markdown/package-lock.json
node-version-file: .nvmrc

2 changes: 1 addition & 1 deletion global.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
"rollForward": "latestFeature",
"allowPrerelease": false
}
}
}
10 changes: 9 additions & 1 deletion tests/authoring/Framework/HtmlAssertions.fs
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,20 @@
let private prettyHtml (html:string) (querySelector: string option) =
let parser = HtmlParser()
let document = parser.ParseDocument(html)

let elementOpt: IElement option =
match querySelector with
| Some q -> Option.ofObj (document.QuerySelector q)
// IHtmlBodyElement implements IElement. document.Body returns IHtmlBodyElement?
// Option.ofObj will handle if document.Body is null (though unlikely for valid HTML documents)
| None -> Option.ofObj (document.Body :> IElement)

Check failure on line 95 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

Nullness warning: A non-nullable 'IElement' was expected but this expression is nullable. Consider either changing the target to also be nullable, or use pattern matching to safely handle the null case of this expression.

Check failure on line 95 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

Nullness warning: The types 'IElement' and 'IElement | null' do not have compatible nullability.

Check failure on line 95 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

Nullness warning: A non-nullable 'IElement' was expected but this expression is nullable. Consider either changing the target to also be nullable, or use pattern matching to safely handle the null case of this expression.

Check failure on line 95 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

Nullness warning: The types 'IElement' and 'IElement | null' do not have compatible nullability.

Check failure on line 95 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

Nullness warning: A non-nullable 'IElement' was expected but this expression is nullable. Consider either changing the target to also be nullable, or use pattern matching to safely handle the null case of this expression.

Check failure on line 95 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

Nullness warning: The types 'IElement' and 'IElement | null' do not have compatible nullability.

Check failure on line 95 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

Nullness warning: A non-nullable 'IElement' was expected but this expression is nullable. Consider either changing the target to also be nullable, or use pattern matching to safely handle the null case of this expression.

Check failure on line 95 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

Nullness warning: The types 'IElement' and 'IElement | null' do not have compatible nullability.

Check failure on line 95 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

Nullness warning: A non-nullable 'IElement' was expected but this expression is nullable. Consider either changing the target to also be nullable, or use pattern matching to safely handle the null case of this expression.

Check failure on line 95 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

Nullness warning: The types 'IElement' and 'IElement | null' do not have compatible nullability.

Check failure on line 95 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

Nullness warning: A non-nullable 'IElement' was expected but this expression is nullable. Consider either changing the target to also be nullable, or use pattern matching to safely handle the null case of this expression.

Check failure on line 95 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

Nullness warning: The types 'IElement' and 'IElement | null' do not have compatible nullability.


let element =
match querySelector with
| Some q -> document.QuerySelector q
| None -> document.Body

let links = element.QuerySelectorAll("a")

Check failure on line 102 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.

Check failure on line 102 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.

Check failure on line 102 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.

Check failure on line 102 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.

Check failure on line 102 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.

Check failure on line 102 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.
links
|> Seq.iter(fun l ->
l.RemoveAttribute "hx-get" |> ignore
Expand All @@ -104,7 +112,7 @@

use sw = new StringWriter()
let formatter = PrettyMarkupFormatter()
element.Children

Check failure on line 115 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.

Check failure on line 115 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.

Check failure on line 115 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.

Check failure on line 115 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.

Check failure on line 115 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.

Check failure on line 115 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.

Check failure on line 115 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.

Check failure on line 115 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.

Check failure on line 115 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.

Check failure on line 115 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.

Check failure on line 115 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.

Check failure on line 115 in tests/authoring/Framework/HtmlAssertions.fs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

Nullness warning: The types 'IParentNode' and 'IParentNode | null' do not have compatible nullability.
|> Seq.indexed
|> Seq.filter (fun (i, c) -> (not <| (i = 0 && c.TagName = "H1")))
|> Seq.map(fun (_, c) -> c)
Expand Down
Loading