-
Notifications
You must be signed in to change notification settings - Fork 29
Product Configuration #1865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Product Configuration #1865
Conversation
…roduct metadata, and substitution support for them
# Conflicts: # config/legacy-url-mappings.yml # src/tooling/docs-assembler/Cli/RepositoryCommands.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elastic/docs-engineering I think this PR would also solve #1497
What happens with existing product subs define in docset.yml files, by the way? Should we prefer products.yml driven substitutions from now on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small nits and q's.
Would be good to include more tests on resolving product names and their attached versioning schemes.
src/Elastic.Documentation.Configuration/ConfigurationFileProvider.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Fabrizio with the save. Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Smoke tests are failing. We should run a full assembler build to validate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're adding possible confusion points in the products.yml file with duplicates or nearly duplicate entries. LMK what you think.
Co-authored-by: florent-leborgne <[email protected]>
I share this confusion - can we maybe reference these in docset.yml so we can keep using the same variables? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
threw some comments on where I could. I suggested a couple of terminology fixes and version # fixes
I'd like to better understand how this actually impacts the functionality of the dropdown - maybe a quick demo could be helpful, or even just explaining using an image of the dropdown what info is populated from where. want to understand what is actually changing with the experience based on these changes
display: 'Elastic Cloud Serverless' | ||
versioning: 'serverless' | ||
cloud-terraform: | ||
display: 'Elastic Cloud Terraform' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have any docs about this product really but I don't think it's stack versioned
https://github.com/elastic/terraform-provider-elasticstack

display: 'Elastic Cloud Terraform' | |
display: 'Elastic Cloud Terraform provider' |
display: 'Elastic Cloud Hosted' | ||
versioning: 'ech' | ||
cloud-kubernetes: | ||
display: 'Elastic Cloud Kubernetes' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
display: 'Elastic Cloud Kubernetes' | |
display: 'Elastic Cloud on Kubernetes' |
display: 'Beats' | ||
versioning: 'stack' | ||
cloud-control-ecctl: | ||
display: 'Elastic Cloud Control ECCTL' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
display: 'Elastic Cloud Control ECCTL' | |
display: 'Elastic Cloud Control' |
display: 'Elasticsearch Curator' | ||
versioning: 'curator' | ||
ecs: | ||
display: 'Elastic Common Schema (ECS)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want brackets on these? @colleenmcginnis
display: 'Elastic Common Schema (ECS) support for zerolog' | ||
versioning: 'ecs_logging_go_zerolog' | ||
ecs-logging-java: | ||
display: 'ECS_based logging for Java applications' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one looks wrong?
also, not seeing this full name used in the libraries docs, e.g. https://www.elastic.co/docs/reference/ecs/logging/java
display: 'ECS_based logging for Java applications' | |
display: 'ECS-based logging for Java applications' |
legacy_versions: *stack | ||
en/elasticsearch/client/curator/: | ||
product: curator | ||
legacy_versions: [ '8.0.21', '7.0', '6.0', '5.8', '5.7', '5.6', '5.5', '5.4', '5.3', '5.2', '5.1', '5.0', '4.3', '4.2', '4.1', '4.0', '3.5', '3.4', '3.3' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8.0.21 is current for curator
product: elastic-agent | ||
legacy_versions: *stack | ||
en/ingest-overview/: | ||
product: elasticsearch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not elasticsearch
product: elasticsearch | ||
legacy_versions: [] | ||
en/ingest/: | ||
product: elasticsearch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not elasticsearch
product: logstash | ||
legacy_versions: *stack | ||
en/machine-learning/: | ||
product: elasticsearch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have a unique product for this although I would argue that it is elasticsearch
product: cloud-serverless | ||
legacy_versions: [] | ||
en/starting-with-the-elasticsearch-platform-and-its-solutions/: | ||
product: elasticsearch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not elasticsearch
Handles #1637
This PR performs a few refactorings into how we deal with product, versioning and legacy URL mapping definitions.
Configuration
products.yml
andlegacy-url-mappings.yml
occurs during early service bootstrapping.Products Listing
products.yml
file to gather essential product metadata. Currently, we have a friendly label for each, and reference the versioning system adopted by the project in question.Versioning
Legacy Url Mapping
legacy-url-mappings.yml
has been reviewed to include a reference to a product. Most entries have a direct correlation. For a few cases, a best-match approach was taken.Docs