-
Couldn't load subscription status.
- Fork 169
Break up explore-analyze code ownership #3629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| /explore-analyze/visualize/ @elastic/experience-docs | ||
|
|
||
| /extend/ @elastic/core-docs | ||
| /get-started/ @elastic/core-docs @elastic/project-docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elastic/project-docs looks like we have a missing link here (see the error at the top of this file)
I think we need to add your team as a subteam of docs, but we should do whatever we did for core/exp/dev/admin/ingest - I can't see how they were added, but they weren't given direct permissions to this repo
until we do that, your team won't be notified on the files you've marked as co-owned
cc: @georgewallace we will probably need your help here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for initiating this. A few of these areas still need to be co-owned, but that's already much better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM like this - I think safe to merge as is
... for more targeted review requests and reduced noise
right now, we can't get away from global notifications for the top-level topics in each of these sections because they're not handled as index files in their respective folders. we could move to that model if we want to cut down on noise further.
Also looked at the other folders where I was familiar with the content, and didn't see any clear wins for breaking down ownership further.