-
Notifications
You must be signed in to change notification settings - Fork 170
ECK: Document recovery from failed volume upsize #3694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ECK: Document recovery from failed volume upsize #3694
Conversation
Signed-off-by: Michael Montgomery <[email protected]>
Signed-off-by: Michael Montgomery <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Michael Montgomery <[email protected]>
Signed-off-by: Michael Montgomery <[email protected]>
Co-authored-by: Peter Brachwitz <[email protected]>
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small suggestions otherwise lgtm.
Signed-off-by: Michael Montgomery <[email protected]>
|
@kilfoyle I pinged you directly for this review as you reviewed the previous PR that I was forced to close. |
| ``` | ||
|
|
||
|
|
||
| ## If a volume expansion failed [k8s-common-problems-volume-failed-expansion] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## If a volume expansion failed [k8s-common-problems-volume-failed-expansion] | |
| ## Volume expansion failed [k8s-common-problems-volume-failed-expansion] |
The original is okay too, but this title format would be more consistent with our other troubleshooting topics, and most of the other ones on this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🏎️
Looks great! Just one small suggestion about the section title.
I had to close #3459 due to my git failures...
In elastic/cloud-on-k8s#4467 it's noted that some users are dealing with volume expansion failure issues, and documenting how to recover from this situation would be helpful. This is the attempt to update that documentation.
After merge