Skip to content

Conversation

@mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Nov 10, 2025

1. What does this PR do?

In the notify github action, do not fail silently, by failing the entire action when the webhook call fails.

2. Which ECS fields are affected/introduced?

N/A

3. Why is this change necessary?

Closes #2565

4. Have you added/updated documentation?

N/A

5. Have you built ECS and committed any newly generated files?

NO

6. Have you run the ECS validation tests locally?

NO

7. Anything else for the reviewers?


Commit Message

In the notify action, when the curl webhook call fails, also fail the entire action, so that webhook will not fail silently.

In the notify action, when the curl webhook call fails, also fail the
entire action, so that webhook will not fail silently.
@mjwolf mjwolf requested a review from a team as a code owner November 10, 2025 23:06
@github-actions
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tool bug] notify action doesn't fail when request fails

1 participant