-
Notifications
You must be signed in to change notification settings - Fork 124
Make is_ready container-image configurable #2593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/test |
Co-authored-by: Jaime Soriano Pastor <[email protected]>
Co-authored-by: Mario Rodriguez Molins <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Just added minor comments.
It would be needed to check if the environment variable can be used to define the docker-compose scenario in the sql_input
test package.
test/packages/parallel/sql_input/_dev/deploy/docker/docker-compose.yml
Outdated
Show resolved
Hide resolved
/test |
💔 Build Failed
Failed CI StepsHistory
|
Co-authored-by: Mario Rodriguez Molins <[email protected]>
…pose.yml Co-authored-by: Mario Rodriguez Molins <[email protected]>
Co-authored-by: Mario Rodriguez Molins <[email protected]>
Co-authored-by: Mario Rodriguez Molins <[email protected]>
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sure, I'll merge this PR. |
Hi everybody,
due to the reduced Docker rate limits, it may happen that the stack can no longer be downloaded because of the is_ready Docker image.
Therefore, I have created an additional environment variable that allows overriding the image.
Best regards
Max