-
Notifications
You must be signed in to change notification settings - Fork 127
Add how to develop with Podman instead of Docker #2927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
ff921ae
c741992
2920a2c
bcee060
bd4f593
f044127
3ad1122
5428508
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -35,6 +35,8 @@ You can run your own custom images for Elasticsearch, Kibana or Elastic Agent, s | |||||
|
||||||
Be aware that a common issue while trying to boot up the stack is that your Docker environments settings are too low in terms of memory threshold. | ||||||
|
||||||
You can use Podman instead of Docker, see [this document](./docs/howto/use_podman.md) | ||||||
|
||||||
For details on how to connect the service with the Elastic stack, see the [service command](https://github.com/elastic/elastic-package/blob/main/README.md#elastic-package-service).` | ||||||
|
||||||
const stackUpLongDescription = `Use this command to boot up the stack locally. | ||||||
|
@@ -45,6 +47,8 @@ You can run your own custom images for Elasticsearch, Kibana or Elastic Agent, s | |||||
|
||||||
Be aware that a common issue while trying to boot up the stack is that your Docker environments settings are too low in terms of memory threshold. | ||||||
|
||||||
You can use Podman instead of Docker, see [this document](./docs/howto/use_podman.md) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
To expose local packages in the Package Registry, build them first and boot up the stack from inside of the Git repository containing the package (e.g. elastic/integrations). They will be copied to the development stack (~/.elastic-package/stack/development) and used to build a custom Docker image of the Package Registry. Starting with Elastic stack version >= 8.7.0, it is not mandatory to be available local packages in the Package Registry to run the tests. | ||||||
|
||||||
For details on how to connect the service with the Elastic stack, see the [service command](https://github.com/elastic/elastic-package/blob/main/README.md#elastic-package-service). | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,8 @@ | ||||||
# How to Develop Using Podman Instead of Docker | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could it be linked this document from the main README? I don't see any reference that As an example, this is done in the integrations repo: https://github.com/elastic/integrations/blob/30cbfa897b15730214495befe29929e9d218c122/docs/extend/quick-start.md?plain=1#L33 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i see it in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Maybe the line you added to But a part from the
So, I'm wondering if it would make sense to just add it to a section in the main README.md as Requirements, Pre-Requisites or under "Getting started". WDYT @jsoriano ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would add it to getting started section, although adding it to the command description might be useful in case of error, looking for help of the command can be a way to discover this content too There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it would be enough with the mention in the getting started section, but I don't see a problem with the line added to command descriptions, so as you prefer. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's be more specific about using Podman Desktop. Podman CLI doens't seem to be enough for the calls to the API as the socket is not exposed.
Suggested change
|
||||||
|
||||||
`elastic-package` Docker-based commands should work out of the box using Podman instead of Docker. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It'd be great to add a test to prove this 🙂 but we can add it if at some point we see users having problems with Podman. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
Check you have **Podman Desktop** configured [following the migration guide](https://podman-desktop.io/docs/migrating-from-docker/managing-docker-compatibility) | ||||||
|
||||||
- [Podman Getting Started](https://podman.io/get-started) | ||||||
- [Podman Docs](https://podman.io/docs) |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -39,6 +39,8 @@ Run the `help` command and see available commands: | |||||
elastic-package help | ||||||
``` | ||||||
|
||||||
Some sub-commands are Docker-based, check you also have Docker installed. In case you are using Podman, check [this guide](./docs/howto/use_podman.md) to make it compatible. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
## Development | ||||||
|
||||||
Even though the project is "go-gettable", there is the [`Makefile`](./Makefile) present, which can be used to build, | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.