internal/elasticsearch/ingest: export LoadIngestPipelineFiles, InstallPipelinesInElasticsearch and GetPipelineNameWithNonce #2943
Conversation
efd6
force-pushed
the
export_pipeline_installation
branch
from
9eea668 to
ea3e2d9
Compare
…lPipelinesInElasticsearch and GetPipelineNameWithNonce
efd6
force-pushed
the
export_pipeline_installation
branch
from
ea3e2d9 to
d9ec1c6
Compare
efd6
changed the title
💚 Build Succeeded
History
cc @efd6 |
There was a problem hiding this comment.
The nonce was an implementation detail to have unique names, I wonder if this should be exposed.
I would prefer to expose an interface like the following one:
// LoadIngestPipelineFiles returns the set of pipelines found in the directory
// elasticsearch/ingest_pipeline under the provided data stream path.
LoadIngestPipelineFiles(dataStreamPath string) ([]Pipeline, error)
// GenerateUniquePipelineNames decorates pipeline names with a suffix
// to ensure they are unique.
GenerateUniquePipelineNames([]Pipeline) []Pipeline
// InstallPipelines installs the provided pipelines into the
// Elasticsearch instance specified by the provided API handle.
InstallPipelines(ctx context.Context, api *elasticsearch.API, pipelines []Pipeline) errorThis way the load and install methods can be used for any case where we need to load or install pipelines, and in the cases where we need to decorate them, we can do it with the other method.
WDYT?
|
|
||
| func getPipelineNameWithNonce(pipelineName string, nonce int64) string { | ||
| // GetPipelineNameWithNonce returns the pipeline name decorated with the provided nonce. | ||
| func GetPipelineNameWithNonce(pipelineName string, nonce int64) string { |
There was a problem hiding this comment.
Why is this method needed out of this package? The pipelines returned by LoadIngestPipelineFiles already include the nonce 🤔
There was a problem hiding this comment.
The nonce is something that ideally I'd like not to exist, but it needs to. Separating them allows me to (mostly) ignore it.
All of these packages are in internal, so I don't think we need to be precious about exporting labels.
For #2868
Please take a look.