Skip to content

Conversation

benwtrent
Copy link
Member

I was debating on having this tests in the original PR anyways. It ain't worth the flakiness. We know the oversampling setting gets updated given the other tests.

closes: #125851

@benwtrent benwtrent added >test Issues or PRs that are addressing/adding tests :Search Relevance/Vectors Vector search v9.1.0 labels Mar 28, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Mar 28, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

Copy link
Contributor

@john-wagster john-wagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benwtrent benwtrent added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 28, 2025
Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞

@elasticsearchmachine elasticsearchmachine merged commit 505f21b into elastic:main Mar 31, 2025
17 checks passed
@benwtrent benwtrent deleted the test/simplify-auto-rescore-tests branch March 31, 2025 12:49
elasticsearchmachine pushed a commit that referenced this pull request Apr 1, 2025
@carlosdelest
Copy link
Member

💚 All backports created successfully

Status Branch Result
8.19

Questions ?

Please refer to the Backport tool documentation

carlosdelest pushed a commit to carlosdelest/elasticsearch that referenced this pull request May 26, 2025
I was debating on having this tests in the original PR anyways. It ain't
worth the flakiness. We know the oversampling setting gets updated given
the other tests.

closes: elastic#125851
(cherry picked from commit 505f21b)

# Conflicts:
#	muted-tests.yml
#	rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.vectors/41_knn_search_bbq_hnsw.yml
carlosdelest added a commit that referenced this pull request May 28, 2025
I was debating on having this tests in the original PR anyways. It ain't
worth the flakiness. We know the oversampling setting gets updated given
the other tests.

closes: #125851
(cherry picked from commit 505f21b)

# Conflicts:
#	muted-tests.yml
#	rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.vectors/41_knn_search_bbq_hnsw.yml

Co-authored-by: Benjamin Trent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] RcsCcsCommonYamlTestSuiteIT test {p0=search.vectors/41_knn_search_bbq_hnsw/Test index configured rescore vector score consistency} failing
4 participants