-
Notifications
You must be signed in to change notification settings - Fork 25.4k
Simplify tests, bypassing raw score test #125877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elasticsearchmachine
merged 3 commits into
elastic:main
from
benwtrent:test/simplify-auto-rescore-tests
Mar 31, 2025
Merged
Simplify tests, bypassing raw score test #125877
elasticsearchmachine
merged 3 commits into
elastic:main
from
benwtrent:test/simplify-auto-rescore-tests
Mar 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
john-wagster
approved these changes
Mar 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
carlosdelest
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😞
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 1, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
carlosdelest
pushed a commit
to carlosdelest/elasticsearch
that referenced
this pull request
May 26, 2025
I was debating on having this tests in the original PR anyways. It ain't worth the flakiness. We know the oversampling setting gets updated given the other tests. closes: elastic#125851 (cherry picked from commit 505f21b) # Conflicts: # muted-tests.yml # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.vectors/41_knn_search_bbq_hnsw.yml
carlosdelest
added a commit
that referenced
this pull request
May 28, 2025
I was debating on having this tests in the original PR anyways. It ain't worth the flakiness. We know the oversampling setting gets updated given the other tests. closes: #125851 (cherry picked from commit 505f21b) # Conflicts: # muted-tests.yml # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.vectors/41_knn_search_bbq_hnsw.yml Co-authored-by: Benjamin Trent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Search Relevance/Vectors
Vector search
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
>test
Issues or PRs that are addressing/adding tests
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was debating on having this tests in the original PR anyways. It ain't worth the flakiness. We know the oversampling setting gets updated given the other tests.
closes: #125851