Skip to content

Set connection: close header on shutdown #128025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DaveCTurner
Copy link
Contributor

@DaveCTurner DaveCTurner commented May 12, 2025

Lets clients using HTTP pipelining know to cease usage of connections to
shutting-down nodes.

Closes #127984

@DaveCTurner DaveCTurner added >enhancement :Distributed Coordination/Network Http and internode communication implementations auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 labels May 12, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @DaveCTurner, I've created a changelog YAML for you.

Lets clients using HTTP pipelining know to cease usage of connections to
shutting-down nodes.

Closes elastic#127984
@DaveCTurner DaveCTurner force-pushed the 2025/05/10/set-connection-close-on-shutdown branch from 8c81e1c to 0ff75db Compare May 12, 2025 09:28
@DaveCTurner DaveCTurner requested a review from mhl-b May 12, 2025 09:28
@DaveCTurner DaveCTurner marked this pull request as ready for review May 12, 2025 09:28
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@elasticsearchmachine
Copy link
Collaborator

Hi @DaveCTurner, I've created a changelog YAML for you.

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label May 12, 2025
@DaveCTurner DaveCTurner requested a review from nicktindall May 12, 2025 09:31
Copy link
Contributor

@nicktindall nicktindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label May 18, 2025
@elasticsearchmachine elasticsearchmachine merged commit 20c02f4 into elastic:main May 18, 2025
17 checks passed
@DaveCTurner DaveCTurner deleted the 2025/05/10/set-connection-close-on-shutdown branch May 18, 2025 20:15
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request May 18, 2025
Lets clients using HTTP pipelining know to cease usage of connections to
shutting-down nodes.

Closes elastic#127984
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.19

elasticsearchmachine pushed a commit that referenced this pull request May 18, 2025
Lets clients using HTTP pipelining know to cease usage of connections to
shutting-down nodes.

Closes #127984
richard-dennehy pushed a commit to richard-dennehy/elasticsearch that referenced this pull request May 19, 2025
Lets clients using HTTP pipelining know to cease usage of connections to
shutting-down nodes.

Closes elastic#127984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Network Http and internode communication implementations >enhancement Team:Distributed Coordination Meta label for Distributed Coordination team v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Connection: close header in HTTP responses when closing
3 participants