Default indexed to false for keyword dimension fields #137029
Draft
+23
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixbarny
reviewed
Oct 23, 2025
|
|
||
| this.dimension = TimeSeriesParams.dimensionParam(m -> toType(m).fieldType().isDimension()).addValidator(v -> { | ||
| if (v && (indexed.getValue() == false || hasDocValues.getValue() == false)) { | ||
| if (v && (hasDocValues.getValue() == false)) { |
There was a problem hiding this comment.
I think this change will need to be applied to all field mappers that can be dimensions:
BooleanFieldMapper
FlattenedFieldMapper
GeoPointFieldMapper
IpFieldMapper
NumberFieldMapper
ScaledFloatFieldMapper
UnsignedLongFieldMapper
There was a problem hiding this comment.
Yes, and it will need gating behind a FeatureFlag and IndexVersion too. This is just for experimenting, really.
There was a problem hiding this comment.
Can we at least also add IpFieldMapper? I think that will be important for the experimentation.
|
I ran this against the metricsgen track. The highlights:
Click to expand full rally comparison |
|
I've extracted flame graphs for two queries that have regressed the most: avg_avgot_cpu_load_1m_filtered_by_hosts_5m-main.html avg_avgot_cpu_load_1m_prefix_by_hosts_5m-main.html What both have in common that they're using a two phase iterator in the skippers version. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.